* [PATCH] drm: make drm_send_event_helper static
@ 2021-03-01 8:19 Jiapeng Chong
2021-03-01 9:16 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-03-01 8:19 UTC (permalink / raw)
To: maarten.lankhorst
Cc: mripard, tzimmermann, airlied, daniel, dri-devel, linux-kernel,
Jiapeng Chong
Fix the following sparse warning:
drivers/gpu/drm/drm_file.c:789:6: warning: symbol
'drm_send_event_helper' was not declared. Should it be static?
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/drm_file.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index 7efbccf..23d8ad4 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -786,8 +786,8 @@ void drm_event_cancel_free(struct drm_device *dev,
* The timestamp variant of dma_fence_signal is used when the caller
* sends a valid timestamp.
*/
-void drm_send_event_helper(struct drm_device *dev,
- struct drm_pending_event *e, ktime_t timestamp)
+static void drm_send_event_helper(struct drm_device *dev, struct drm_pending_event *e,
+ ktime_t timestamp)
{
assert_spin_locked(&dev->event_lock);
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm: make drm_send_event_helper static
2021-03-01 8:19 [PATCH] drm: make drm_send_event_helper static Jiapeng Chong
@ 2021-03-01 9:16 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2021-03-01 9:16 UTC (permalink / raw)
To: Jiapeng Chong
Cc: maarten.lankhorst, mripard, tzimmermann, airlied, daniel,
dri-devel, linux-kernel
On Mon, Mar 01, 2021 at 04:19:50PM +0800, Jiapeng Chong wrote:
> Fix the following sparse warning:
>
> drivers/gpu/drm/drm_file.c:789:6: warning: symbol
> 'drm_send_event_helper' was not declared. Should it be static?
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/drm_file.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
> index 7efbccf..23d8ad4 100644
> --- a/drivers/gpu/drm/drm_file.c
> +++ b/drivers/gpu/drm/drm_file.c
> @@ -786,8 +786,8 @@ void drm_event_cancel_free(struct drm_device *dev,
> * The timestamp variant of dma_fence_signal is used when the caller
> * sends a valid timestamp.
> */
> -void drm_send_event_helper(struct drm_device *dev,
> - struct drm_pending_event *e, ktime_t timestamp)
> +static void drm_send_event_helper(struct drm_device *dev, struct drm_pending_event *e,
> + ktime_t timestamp)
For static inline functions we also remove the kerneldoc, there's not
really anything important in there. Can you pls do that and respin your
patch?
Thanks, Daniel
> {
> assert_spin_locked(&dev->event_lock);
>
> --
> 1.8.3.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-01 9:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-01 8:19 [PATCH] drm: make drm_send_event_helper static Jiapeng Chong
2021-03-01 9:16 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®