From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
"Ahmed S. Darwish" <a.darwish@linutronix.de>,
Denis Kirjanov <kda@linux-powerpc.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, ath9k-devel@qca.qualcomm.com,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, Chas Williams <3chas3@gmail.com>,
linux-atm-general@lists.sourceforge.net,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
linux1394-devel@lists.sourceforge.net
Subject: Re: [patch 00/14] tasklets: Replace the spin wait loops and make it RT safe
Date: Tue, 9 Mar 2021 15:04:50 +0100 [thread overview]
Message-ID: <YEeAghrP8cOk1zL9@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20210309084203.995862150@linutronix.de>
On Tue, Mar 09, 2021 at 09:42:03AM +0100, Thomas Gleixner wrote:
> This is a follow up to the review comments of the series which makes
> softirq processing PREEMPT_RT safe:
>
> https://lore.kernel.org/r/20201207114743.GK3040@hirez.programming.kicks-ass.net
>
> Peter suggested to replace the spin waiting in tasklet_disable() and
> tasklet_kill() with wait_event(). This also gets rid of the ill defined
> sched_yield() in tasklet_kill().
>
> Analyzing all usage sites of tasklet_disable() and tasklet_unlock_wait() we
> found that most of them are safe to be converted to a sleeping wait.
>
> Only a few instances invoke tasklet_disable() from atomic context. A few
> bugs which have been found in course of this analysis have been already
> addressed seperately.
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
prev parent reply other threads:[~2021-03-09 14:06 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 8:42 Thomas Gleixner
2021-03-09 8:42 ` [patch 01/14] tasklets: Replace barrier() with cpu_relax() in tasklet_unlock_wait() Thomas Gleixner
2021-03-17 15:49 ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2021-03-09 8:42 ` [patch 02/14] tasklets: Use static inlines for stub implementations Thomas Gleixner
2021-03-17 15:48 ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2021-03-09 8:42 ` [patch 03/14] tasklets: Provide tasklet_disable_in_atomic() Thomas Gleixner
2021-03-17 15:48 ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2021-03-09 8:42 ` [patch 04/14] tasklets: Use spin wait in tasklet_disable() temporarily Thomas Gleixner
2021-03-17 15:48 ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2021-03-09 8:42 ` [patch 05/14] tasklets: Replace spin wait in tasklet_unlock_wait() Thomas Gleixner
2021-03-17 15:48 ` [tip: irq/core] " tip-bot2 for Peter Zijlstra
2021-03-09 8:42 ` [patch 06/14] tasklets: Replace spin wait in tasklet_kill() Thomas Gleixner
2021-03-17 15:48 ` [tip: irq/core] " tip-bot2 for Peter Zijlstra
2021-03-09 8:42 ` [patch 07/14] tasklets: Prevent tasklet_unlock_spin_wait() deadlock on RT Thomas Gleixner
2021-03-09 15:00 ` Sebastian Andrzej Siewior
2021-03-09 15:21 ` Sebastian Andrzej Siewior
2021-03-10 8:35 ` Thomas Gleixner
2021-03-17 15:48 ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2021-03-09 8:42 ` [patch 08/14] net: jme: Replace link-change tasklet with work Thomas Gleixner
2021-03-17 15:48 ` [tip: irq/core] " tip-bot2 for Sebastian Andrzej Siewior
2021-03-09 8:42 ` [patch 09/14] net: sundance: Use tasklet_disable_in_atomic() Thomas Gleixner
2021-03-17 15:48 ` [tip: irq/core] " tip-bot2 for Sebastian Andrzej Siewior
2021-03-09 8:42 ` [patch 10/14] ath9k: " Thomas Gleixner
2021-03-09 10:23 ` Kalle Valo
2021-03-17 15:48 ` [tip: irq/core] " tip-bot2 for Sebastian Andrzej Siewior
2021-03-09 8:42 ` [patch 11/14] atm: eni: Use tasklet_disable_in_atomic() in the send() callback Thomas Gleixner
2021-03-17 15:48 ` [tip: irq/core] " tip-bot2 for Sebastian Andrzej Siewior
2021-03-09 8:42 ` [patch 12/14] PCI: hv: Use tasklet_disable_in_atomic() Thomas Gleixner
2021-03-09 22:17 ` Bjorn Helgaas
2021-03-10 11:34 ` Wei Liu
2021-03-17 15:48 ` [tip: irq/core] " tip-bot2 for Sebastian Andrzej Siewior
2021-03-09 8:42 ` [patch 13/14] firewire: ohci: Use tasklet_disable_in_atomic() where required Thomas Gleixner
2021-03-17 15:48 ` [tip: irq/core] " tip-bot2 for Sebastian Andrzej Siewior
2021-03-09 8:42 ` [patch 14/14] tasklets: Switch tasklet_disable() to the sleep wait variant Thomas Gleixner
2021-03-17 15:48 ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2021-03-09 14:04 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEeAghrP8cOk1zL9@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=3chas3@gmail.com \
--cc=a.darwish@linutronix.de \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=bhelgaas@google.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=frederic@kernel.org \
--cc=haiyangz@microsoft.com \
--cc=kda@linux-powerpc.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=kys@microsoft.com \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=lorenzo.pieralisi@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®