From: Greg KH <gregkh@linuxfoundation.org>
To: Min Li <min.li.xe@renesas.com>
Cc: "derek.kiernan@xilinx.com" <derek.kiernan@xilinx.com>,
"dragan.cvetic@xilinx.com" <dragan.cvetic@xilinx.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v3 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support
Date: Fri, 9 Apr 2021 08:44:01 +0200 [thread overview]
Message-ID: <YG/3sZZZbsqdzARx@kroah.com> (raw)
In-Reply-To: <OSBPR01MB47730D5F401A895C84849CCDBA749@OSBPR01MB4773.jpnprd01.prod.outlook.com>
On Thu, Apr 08, 2021 at 06:59:19PM +0000, Min Li wrote:
> >
> > But what does that have to do with the misc device?
> >
>
> Hi Greg, MFD driver is the start of everything. Once MFD driver is loading, it will spawn 2 devices,
> one is for phc driver, which is under /driver/ptp and the other one is for this misc driver.
> Both PHC and misc drivers are operating on the same device.
> They are both calling exported functions from mfd drivers to access the device through i2c/spi
> and the register definitions are located in include/Linux/mfd/idt8a340_reg.h or idt82p33_reg.h
> depending on which device was found by mfd driver through device tree node.
I don't think it's a good idea to have the same defines with different
values in different files, that's just a problem waiting to happen...
good luck!
greg k-h
next prev parent reply other threads:[~2021-04-09 6:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 1:50 [PATCH net-next v3 1/2] mfd: " min.li.xe
2021-04-08 1:50 ` [PATCH net-next v3 2/2] misc: " min.li.xe
2021-04-08 6:22 ` Greg KH
2021-04-08 17:26 ` Min Li
2021-04-08 17:54 ` Greg KH
2021-04-08 18:01 ` Min Li
2021-04-08 18:10 ` Greg KH
2021-04-08 18:59 ` Min Li
2021-04-09 6:44 ` Greg KH [this message]
2021-04-08 7:08 ` [PATCH net-next v3 1/2] mfd: " Lee Jones
2021-04-08 17:38 ` Min Li
2021-04-09 10:02 ` Lee Jones
2021-04-09 13:57 ` Min Li
2021-04-11 14:10 ` Min Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG/3sZZZbsqdzARx@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=derek.kiernan@xilinx.com \
--cc=dragan.cvetic@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=min.li.xe@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®