mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Min Li <min.li.xe@renesas.com>
Cc: "derek.kiernan@xilinx.com" <derek.kiernan@xilinx.com>,
	"dragan.cvetic@xilinx.com" <dragan.cvetic@xilinx.com>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v3 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support
Date: Thu, 8 Apr 2021 19:54:04 +0200	[thread overview]
Message-ID: <YG9DPEyOIXqS2Vss@kroah.com> (raw)
In-Reply-To: <OSBPR01MB4773182AF8FD263D65D52949BA749@OSBPR01MB4773.jpnprd01.prod.outlook.com>

On Thu, Apr 08, 2021 at 05:26:40PM +0000, Min Li wrote:
> > 
> > Again, please make this only one file.
> > 
> Hi Greg, the 2 boards have some same named registers in idt82p33_reg.h and idt8a340_reg.h
> so if I put them all in the same file, there will be name conflicts. 

That does not make sense, this is only one kernel module, with one .h
file in this patch, I do not see those other files you are talking
about...

And if you have named registers that are identical, and yet you only
work on one device, that feels like a design flaw somewhere :)

thanks,

greg k-h

  reply	other threads:[~2021-04-08 17:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08  1:50 [PATCH net-next v3 1/2] mfd: " min.li.xe
2021-04-08  1:50 ` [PATCH net-next v3 2/2] misc: " min.li.xe
2021-04-08  6:22   ` Greg KH
2021-04-08 17:26     ` Min Li
2021-04-08 17:54       ` Greg KH [this message]
2021-04-08 18:01         ` Min Li
2021-04-08 18:10           ` Greg KH
2021-04-08 18:59             ` Min Li
2021-04-09  6:44               ` Greg KH
2021-04-08  7:08 ` [PATCH net-next v3 1/2] mfd: " Lee Jones
2021-04-08 17:38   ` Min Li
2021-04-09 10:02     ` Lee Jones
2021-04-09 13:57       ` Min Li
2021-04-11 14:10       ` Min Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YG9DPEyOIXqS2Vss@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=derek.kiernan@xilinx.com \
    --cc=dragan.cvetic@xilinx.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=min.li.xe@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®