* [PATCH] usb: gadget: aspeed: Remove unnecessary version.h includes
@ 2021-04-06 3:59 Jiapeng Chong
2021-04-06 5:26 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Jiapeng Chong @ 2021-04-06 3:59 UTC (permalink / raw)
To: balbi
Cc: gregkh, joel, andrew, linux-usb, linux-arm-kernel, linux-aspeed,
linux-kernel, Jiapeng Chong
"make versioncheck" shows:
./drivers/usb/gadget/udc/aspeed-vhub/hub.c: 33 linux/version.h not
needed.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/usb/gadget/udc/aspeed-vhub/hub.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/aspeed-vhub/hub.c b/drivers/usb/gadget/udc/aspeed-vhub/hub.c
index 5c7dea5..e5bbc0c 100644
--- a/drivers/usb/gadget/udc/aspeed-vhub/hub.c
+++ b/drivers/usb/gadget/udc/aspeed-vhub/hub.c
@@ -30,7 +30,6 @@
#include <linux/regmap.h>
#include <linux/dma-mapping.h>
#include <linux/bcd.h>
-#include <linux/version.h>
#include <linux/usb.h>
#include <linux/usb/hcd.h>
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: gadget: aspeed: Remove unnecessary version.h includes
2021-04-06 3:59 [PATCH] usb: gadget: aspeed: Remove unnecessary version.h includes Jiapeng Chong
@ 2021-04-06 5:26 ` Greg KH
2021-04-21 2:06 ` 种嘉鹏
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2021-04-06 5:26 UTC (permalink / raw)
To: Jiapeng Chong
Cc: balbi, joel, andrew, linux-usb, linux-arm-kernel, linux-aspeed,
linux-kernel
On Tue, Apr 06, 2021 at 11:59:58AM +0800, Jiapeng Chong wrote:
> "make versioncheck" shows:
>
> ./drivers/usb/gadget/udc/aspeed-vhub/hub.c: 33 linux/version.h not
> needed.
Then you need to fix the tool, and always test-build patches before you
send them out, as this is obviously wrong :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: gadget: aspeed: Remove unnecessary version.h includes
2021-04-06 5:26 ` Greg KH
@ 2021-04-21 2:06 ` 种嘉鹏
0 siblings, 0 replies; 3+ messages in thread
From: 种嘉鹏 @ 2021-04-21 2:06 UTC (permalink / raw)
To: Greg KH; +Cc: balbi, linux-usb, linux-arm-kernel, linux-aspeed, linux-kernel
On 2021/4/6 13:26, Greg KH wrote:
> On Tue, Apr 06, 2021 at 11:59:58AM +0800, Jiapeng Chong wrote:
>> "make versioncheck" shows:
>>
>> ./drivers/usb/gadget/udc/aspeed-vhub/hub.c: 33 linux/version.h not
>> needed.
>
> Then you need to fix the tool, and always test-build patches before you
> send them out, as this is obviously wrong :(
>
Sorry for the noise. We'll do more test-build towards patches next time.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-21 2:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-06 3:59 [PATCH] usb: gadget: aspeed: Remove unnecessary version.h includes Jiapeng Chong
2021-04-06 5:26 ` Greg KH
2021-04-21 2:06 ` 种嘉鹏
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®