* [PATCH] drm: Fix misleading documentation of drm_gem_cma_create()
@ 2021-06-01 9:54 Paul Cercueil
2021-06-01 16:12 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Paul Cercueil @ 2021-06-01 9:54 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann
Cc: David Airlie, Daniel Vetter, dri-devel, linux-kernel, list,
Tomi Valkeinen, Paul Cercueil
The backing memory does not necessarily have the writecombine attribute
set, since commit cf8ccbc72d61 ("drm: Add support for GEM buffers backed
by non-coherent memory").
Fixes: cf8ccbc72d61 ("drm: Add support for GEM buffers backed by non-coherent memory")
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
drivers/gpu/drm/drm_gem_cma_helper.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
index 4a24af2c5c43..d53388199f34 100644
--- a/drivers/gpu/drm/drm_gem_cma_helper.c
+++ b/drivers/gpu/drm/drm_gem_cma_helper.c
@@ -104,8 +104,7 @@ __drm_gem_cma_create(struct drm_device *drm, size_t size, bool private)
* @size: size of the object to allocate
*
* This function creates a CMA GEM object and allocates a contiguous chunk of
- * memory as backing store. The backing memory has the writecombine attribute
- * set.
+ * memory as backing store.
*
* Returns:
* A struct drm_gem_cma_object * on success or an ERR_PTR()-encoded negative
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm: Fix misleading documentation of drm_gem_cma_create()
2021-06-01 9:54 [PATCH] drm: Fix misleading documentation of drm_gem_cma_create() Paul Cercueil
@ 2021-06-01 16:12 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2021-06-01 16:12 UTC (permalink / raw)
To: Paul Cercueil
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, dri-devel, linux-kernel, list,
Tomi Valkeinen
On Tue, Jun 01, 2021 at 10:54:05AM +0100, Paul Cercueil wrote:
> The backing memory does not necessarily have the writecombine attribute
> set, since commit cf8ccbc72d61 ("drm: Add support for GEM buffers backed
> by non-coherent memory").
>
> Fixes: cf8ccbc72d61 ("drm: Add support for GEM buffers backed by non-coherent memory")
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/drm_gem_cma_helper.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
> index 4a24af2c5c43..d53388199f34 100644
> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
> @@ -104,8 +104,7 @@ __drm_gem_cma_create(struct drm_device *drm, size_t size, bool private)
> * @size: size of the object to allocate
> *
> * This function creates a CMA GEM object and allocates a contiguous chunk of
> - * memory as backing store. The backing memory has the writecombine attribute
> - * set.
> + * memory as backing store.
> *
> * Returns:
> * A struct drm_gem_cma_object * on success or an ERR_PTR()-encoded negative
> --
> 2.30.2
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-01 16:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 9:54 [PATCH] drm: Fix misleading documentation of drm_gem_cma_create() Paul Cercueil
2021-06-01 16:12 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®