From: Borislav Petkov <bp@alien8.de>
To: Steve Rutherford <srutherford@google.com>
Cc: Ashish Kalra <Ashish.Kalra@amd.com>,
pbonzini@redhat.com, seanjc@google.com, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, joro@8bytes.org,
thomas.lendacky@amd.com, x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, brijesh.singh@amd.com
Subject: Re: [PATCH v4 5/5] x86/kvm: Add guest support for detecting and enabling SEV Live Migration feature.
Date: Sat, 26 Jun 2021 00:22:52 +0200 [thread overview]
Message-ID: <YNZXPEPxv54UmzNj@zn.tnic> (raw)
In-Reply-To: <CABayD+ckOsM4+sab00SggrH3_iFaiV-7h9tHHuL1J-o6_YQVKA@mail.gmail.com>
On Fri, Jun 25, 2021 at 02:02:32PM -0700, Steve Rutherford wrote:
> Boris, do you have any thoughts on the kexec aspect of this change?
I'm suspecting you're asking here the wrong guy - I think you mean
Paolo.
But if I were to give some thoughts on this, I'd first request that this
patch be split because it is doing a bunch of things at once.
Then, I have no clue what "kexec support for SEV Live Migration" is. So
this whole use case would need a lot more detailed explanation of all
the moving parts and the "why" and the "because" and so on...
But I'm no virt guy so perhaps this all makes sense to virt folks.
Oh, and there's silly stuff like
+static int __init setup_efi_kvm_sev_migration(void)
{
...
return true;
}
returning a bool but that's minor.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-06-25 22:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1623421410.git.ashish.kalra@amd.com>
2021-06-11 14:26 ` [PATCH v4 3/5] mm: x86: Invoke hypercall when page encryption status is changed Ashish Kalra
2021-06-11 14:28 ` [PATCH v4 4/5] EFI: Introduce the new AMD Memory Encryption GUID Ashish Kalra
2021-06-11 14:30 ` [PATCH v4 5/5] x86/kvm: Add guest support for detecting and enabling SEV Live Migration feature Ashish Kalra
2021-06-25 21:02 ` Steve Rutherford
2021-06-25 22:22 ` Borislav Petkov [this message]
2021-06-28 19:34 ` Ashish Kalra
2021-06-28 20:37 ` Steve Rutherford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNZXPEPxv54UmzNj@zn.tnic \
--to=bp@alien8.de \
--cc=Ashish.Kalra@amd.com \
--cc=brijesh.singh@amd.com \
--cc=hpa@zytor.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=srutherford@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®