From: Peter Zijlstra <peterz@infradead.org>
To: Huaixin Chang <changhuaixin@linux.alibaba.com>
Cc: luca.abeni@santannapisa.it, anderson@cs.unc.edu,
baruah@wustl.edu, bsegall@google.com, dietmar.eggemann@arm.com,
dtcccc@linux.alibaba.com, juri.lelli@redhat.com,
khlebnikov@yandex-team.ru, linux-kernel@vger.kernel.org,
mgorman@suse.de, mingo@redhat.com, odin@uged.al, odin@ugedal.com,
pauld@redhead.com, pjt@google.com, rostedt@goodmis.org,
shanpeic@linux.alibaba.com, tj@kernel.org,
tommaso.cucinotta@santannapisa.it, vincent.guittot@linaro.org,
xiyou.wangcong@gmail.com
Subject: Re: [PATCH v6 2/3] sched/fair: Add cfs bandwidth burst statistics
Date: Mon, 28 Jun 2021 17:12:17 +0200 [thread overview]
Message-ID: <YNnm0bUfCmB54FYW@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <YNnkDnJtliEInwTY@hirez.programming.kicks-ass.net>
On Mon, Jun 28, 2021 at 05:00:30PM +0200, Peter Zijlstra wrote:
> I was hoping we could get away with something simpler, like maybe:
>
> u64 old_runtim = cfs_b->runtime;
>
> cfs_b->runtime += cfs_b->quota
> cfs_b->runtime = min(cfs_b->runtime, cfs_b->quota + cfs_b->burst);
>
> if (cfs_b->runtime - old_runtime > cfs_b->quota)
> cfs_b->nr_bursts++;
>
> Would that be good enough?
Bah,, of course not ... :-/ At best we can detect == quota, which might
be a good enough indicator of burst.
next prev parent reply other threads:[~2021-06-28 15:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 9:27 [PATCH v6 0/3] sched/fair: Burstable CFS bandwidth controller Huaixin Chang
2021-06-21 9:27 ` [PATCH v6 1/3] sched/fair: Introduce the burstable CFS controller Huaixin Chang
2021-06-22 13:19 ` Peter Zijlstra
2021-06-22 18:57 ` Benjamin Segall
2021-06-24 8:48 ` changhuaixin
2021-06-24 9:28 ` Peter Zijlstra
2021-06-22 15:27 ` Odin Ugedal
2021-06-23 8:47 ` Peter Zijlstra
2021-06-24 8:45 ` changhuaixin
2021-06-24 7:39 ` [tip: sched/core] " tip-bot2 for Huaixin Chang
2021-06-21 9:27 ` [PATCH v6 2/3] sched/fair: Add cfs bandwidth burst statistics Huaixin Chang
2021-06-28 15:00 ` Peter Zijlstra
2021-06-28 15:12 ` Peter Zijlstra [this message]
2021-07-02 11:31 ` changhuaixin
2021-06-21 9:28 ` [PATCH v6 3/3] sched/fair: Add document for burstable CFS bandwidth Huaixin Chang
2021-06-22 15:26 ` Odin Ugedal
2021-06-22 14:25 ` [PATCH v6 0/3] sched/fair: Burstable CFS bandwidth controller Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNnm0bUfCmB54FYW@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=anderson@cs.unc.edu \
--cc=baruah@wustl.edu \
--cc=bsegall@google.com \
--cc=changhuaixin@linux.alibaba.com \
--cc=dietmar.eggemann@arm.com \
--cc=dtcccc@linux.alibaba.com \
--cc=juri.lelli@redhat.com \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@santannapisa.it \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=odin@uged.al \
--cc=odin@ugedal.com \
--cc=pauld@redhead.com \
--cc=pjt@google.com \
--cc=rostedt@goodmis.org \
--cc=shanpeic@linux.alibaba.com \
--cc=tj@kernel.org \
--cc=tommaso.cucinotta@santannapisa.it \
--cc=vincent.guittot@linaro.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®