From: andy@surfacebook.localdomain
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Tony Lindgren <tony@atomide.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org, linux-omap@vger.kernel.org,
Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: 8250: 8250_omap: Fix possible interrupt storm
Date: Mon, 12 Jul 2021 23:27:08 +0300 [thread overview]
Message-ID: <YOylnHudkwcHHEeZ@surfacebook.localdomain> (raw)
In-Reply-To: <56c5d73f-741c-2643-1c79-6dc13ebb05c7@ti.com>
Tue, Jun 22, 2021 at 11:53:38AM +0530, Vignesh Raghavendra kirjoitti:
> On 6/22/21 11:45 AM, Jan Kiszka wrote:
> >>> Vignesh, it seems this quirk needs some soc specific flag added to
> >>> it maybe? Or maybe UART_OMAP_RX_LVL register is not available for
> >>> all the SoCs?
> >>>
> >> Yes indeed :(
> >>
> >>> I think it's best to drop this patch until the issues are resolved,
> >>> also there are some open comments above that might be answered by
> >>> limiting this quirk to a specific range of SoCs :)
> >>>
> >> Oops, I did test patch AM33xx assuming its equivalent to OMAP3, but UART
> >> IP is quite different. I will respin the patch making sure, workaround
> >> applies only to AM65x and K3 SoCs.
> >>
> >> Regards
> >> Vignesh
> >>
> > What's the status here for AM65x? The issue remains present on that
> > platform, and I was hoping to see a quick follow up that limit the fix
> > to that target.
>
> Sorry for the delay, I am trying to find which other TI SoCs are
> affected by this issue. But that exercise will need a bit more time.
> Will send a fix to address K3 SoCs like AM65x today/tomo.
This all reminds me the very similar issue one found on Intel integrated
(Synopsys DesignWare based) UARTs:
https://lore.kernel.org/linux-serial/20170206233000.3021-1-dianders@chromium.org/
https://lore.kernel.org/linux-serial/1440015124-28393-1-git-send-email-california.l.sullivan@intel.com/
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-07-12 20:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 15:19 Vignesh Raghavendra
2021-05-13 14:17 ` Greg Kroah-Hartman
2021-05-28 5:39 ` Tony Lindgren
2021-05-28 6:11 ` Vignesh Raghavendra
2021-05-28 9:00 ` Greg Kroah-Hartman
2021-06-22 6:15 ` Jan Kiszka
2021-06-22 6:23 ` Vignesh Raghavendra
2021-07-12 20:27 ` andy [this message]
2021-07-13 8:54 ` Vignesh Raghavendra
2021-07-13 9:09 ` Andy Shevchenko
2021-07-13 9:13 ` Andy Shevchenko
2021-07-27 10:39 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOylnHudkwcHHEeZ@surfacebook.localdomain \
--to=andy@surfacebook.localdomain \
--cc=gregkh@linuxfoundation.org \
--cc=jan.kiszka@siemens.com \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®