mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: brookxu <brookxu.cn@gmail.com>
Cc: lizefan.x@bytedance.com, hannes@cmpxchg.org,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH] misc_cgroup: use a counter to count the number of failures
Date: Fri, 13 Aug 2021 06:16:45 -1000	[thread overview]
Message-ID: <YRaa7R6niNQMpqZm@mtj.duckdns.org> (raw)
In-Reply-To: <1628832371-16382-1-git-send-email-brookxu.cn@gmail.com>

Hello,

On Fri, Aug 13, 2021 at 01:26:11PM +0800, brookxu wrote:
> From: Chunguang Xu <brookxu@tencent.com>
> 
> For a container, we only print an error log when the resource
> charge fails. There may be some problems here:
> 
> 1. If a large number of containers are created and deleted,
>    there will be a lot of error logs.
> 2. According to an error log, we cannot better understand
>    the actual pressure of resources.
> 
> Therefore, perhaps we should use a failcnt counter to count
> the number of failures, so that we can easily understand the
> actual pressure of resources and avoid too many error log..
> 
> This is a partial patch of the previous serial, which may
> be useful, so I resend it.

I think this approach is fine but can you please

* Cc the original author of the misc cgroup who added the warning
  messages.

* Rename failcnt to nr_fails?

Thanks.

-- 
tejun

      reply	other threads:[~2021-08-13 16:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13  5:26 brookxu
2021-08-13 16:16 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRaa7R6niNQMpqZm@mtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=brookxu.cn@gmail.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan.x@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®