From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bryan Brattlof <hello@bryanbrattlof.com>
Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8723bs: remove sdio_osintf.h
Date: Thu, 26 Aug 2021 12:07:38 +0200 [thread overview]
Message-ID: <YSdn6vLOo/WG/9rS@kroah.com> (raw)
In-Reply-To: <20210823221156.3353972-1-hello@bryanbrattlof.com>
On Mon, Aug 23, 2021 at 10:12:21PM +0000, Bryan Brattlof wrote:
> All definitions inside sdio_osintf.h are unused. Remove it.
>
> Signed-off-by: Bryan Brattlof <hello@bryanbrattlof.com>
> ---
> drivers/staging/rtl8723bs/include/drv_types.h | 1 -
> drivers/staging/rtl8723bs/include/sdio_osintf.h | 16 ----------------
> 2 files changed, 17 deletions(-)
> delete mode 100644 drivers/staging/rtl8723bs/include/sdio_osintf.h
>
> diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/staging/rtl8723bs/include/drv_types.h
> index 580028d28c42..0e6741db95bf 100644
> --- a/drivers/staging/rtl8723bs/include/drv_types.h
> +++ b/drivers/staging/rtl8723bs/include/drv_types.h
> @@ -489,7 +489,6 @@ static inline u8 *myid(struct eeprom_priv *peepriv)
> }
>
> /* HCI Related header file */
> -#include <sdio_osintf.h>
> #include <sdio_ops.h>
> #include <sdio_hal.h>
>
> diff --git a/drivers/staging/rtl8723bs/include/sdio_osintf.h b/drivers/staging/rtl8723bs/include/sdio_osintf.h
> deleted file mode 100644
> index 146b44f95e29..000000000000
> --- a/drivers/staging/rtl8723bs/include/sdio_osintf.h
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -/******************************************************************************
> - *
> - * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved.
> - *
> - ******************************************************************************/
> -#ifndef __SDIO_OSINTF_H__
> -#define __SDIO_OSINTF_H__
> -
> -
> -
> -u8 sd_hal_bus_init(struct adapter *padapter);
> -u8 sd_hal_bus_deinit(struct adapter *padapter);
> -void sd_c2h_hdl(struct adapter *padapter);
What about the instances in
drivers/staging/rtl8723bs/include/sdio_hal.h? Please remove them at the
same time.
thanks,
greg k-h
prev parent reply other threads:[~2021-08-26 10:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 22:12 Bryan Brattlof
2021-08-26 10:07 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSdn6vLOo/WG/9rS@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hello@bryanbrattlof.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®