* Re: [PATCH] ARM: omap1: move omap15xx local bus handling to usb.c
[not found] <20210927144118.2464881-1-arnd@kernel.org>
@ 2021-09-27 15:06 ` Alan Stern
2021-09-28 6:31 ` Tony Lindgren
1 sibling, 0 replies; 2+ messages in thread
From: Alan Stern @ 2021-09-27 15:06 UTC (permalink / raw)
To: Arnd Bergmann
Cc: soc, Aaro Koskinen, Tony Lindgren, Greg Kroah-Hartman,
Arnd Bergmann, Felipe Balbi, linux-omap, linux-arm-kernel,
linux-kernel, linux-usb
On Mon, Sep 27, 2021 at 04:40:50PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Commit 38225f2ef2f4 ("ARM/omap1: switch to use dma_direct_set_offset for
> lbus DMA offsets") removed a lot of mach/memory.h, but left the USB
> offset handling split into arch/arm/mach-omap1/usb.c and
> drivers/usb/host/ohci-omap.c.
>
> This can cause a randconfig build warning that now fails the build
> with -Werror:
>
> arch/arm/mach-omap1/usb.c:561:30: error: 'omap_1510_usb_ohci_nb' defined but not used [-Werror=unused-variable]
> 561 | static struct notifier_block omap_1510_usb_ohci_nb = {
> | ^~~~~~~~~~~~~~~~~~~~~
>
> Move it all into the platform file to get rid of the final
> location that relies on mach/memory.h.
>
> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
For the ohci-omap.c portion:
Acked-by: Alan Stern <stern@rowland.harvard.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ARM: omap1: move omap15xx local bus handling to usb.c
[not found] <20210927144118.2464881-1-arnd@kernel.org>
2021-09-27 15:06 ` [PATCH] ARM: omap1: move omap15xx local bus handling to usb.c Alan Stern
@ 2021-09-28 6:31 ` Tony Lindgren
1 sibling, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2021-09-28 6:31 UTC (permalink / raw)
To: Arnd Bergmann
Cc: soc, Aaro Koskinen, Alan Stern, Greg Kroah-Hartman,
Arnd Bergmann, Felipe Balbi, linux-omap, linux-arm-kernel,
linux-kernel, linux-usb
* Arnd Bergmann <arnd@kernel.org> [210927 14:41]:
> From: Arnd Bergmann <arnd@arndb.de>
> If there are no objections, I'd apply this to the soc tree for
> 5.16, or let Tony pick it up into his tree. This was originally
> part of a longer series to bring omap1 closer to an allmodconfig
> build. If I manage to find some time, I'll also try to resurrect
> the rest of that series.
Looks good to me, it should not conflict with anything else so please
feel free to apply:
Acked-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 2+ messages in thread