* [PATCH] mtip32xx: Remove redundant 'flush_workqueue()' calls
@ 2021-10-14 18:07 Christophe JAILLET
2021-10-16 4:31 ` Christoph Hellwig
2021-10-16 22:11 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2021-10-14 18:07 UTC (permalink / raw)
To: axboe, liushixin2, bhelgaas
Cc: linux-block, linux-kernel, kernel-janitors, Christophe JAILLET
'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.
Remove the redundant 'flush_workqueue()' calls.
This was generated with coccinelle:
@@
expression E;
@@
- flush_workqueue(E);
destroy_workqueue(E);
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/block/mtip32xx/mtip32xx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index d0b40309f47e..c91b9010c1a6 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -4063,7 +4063,6 @@ static int mtip_pci_probe(struct pci_dev *pdev,
msi_initialize_err:
if (dd->isr_workq) {
- flush_workqueue(dd->isr_workq);
destroy_workqueue(dd->isr_workq);
drop_cpu(dd->work[0].cpu_binding);
drop_cpu(dd->work[1].cpu_binding);
@@ -4121,7 +4120,6 @@ static void mtip_pci_remove(struct pci_dev *pdev)
mtip_block_remove(dd);
if (dd->isr_workq) {
- flush_workqueue(dd->isr_workq);
destroy_workqueue(dd->isr_workq);
drop_cpu(dd->work[0].cpu_binding);
drop_cpu(dd->work[1].cpu_binding);
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mtip32xx: Remove redundant 'flush_workqueue()' calls
2021-10-14 18:07 [PATCH] mtip32xx: Remove redundant 'flush_workqueue()' calls Christophe JAILLET
@ 2021-10-16 4:31 ` Christoph Hellwig
2021-10-16 22:11 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2021-10-16 4:31 UTC (permalink / raw)
To: Christophe JAILLET
Cc: axboe, liushixin2, bhelgaas, linux-block, linux-kernel, kernel-janitors
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtip32xx: Remove redundant 'flush_workqueue()' calls
2021-10-14 18:07 [PATCH] mtip32xx: Remove redundant 'flush_workqueue()' calls Christophe JAILLET
2021-10-16 4:31 ` Christoph Hellwig
@ 2021-10-16 22:11 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2021-10-16 22:11 UTC (permalink / raw)
To: Christophe JAILLET, bhelgaas, liushixin2
Cc: Jens Axboe, linux-kernel, linux-block, kernel-janitors
On Thu, 14 Oct 2021 20:07:50 +0200, Christophe JAILLET wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> This was generated with coccinelle:
>
> [...]
Applied, thanks!
[1/1] mtip32xx: Remove redundant 'flush_workqueue()' calls
commit: 82c2ecfce69bb758faf81779e28e0ea1a342f1a7
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-16 22:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-14 18:07 [PATCH] mtip32xx: Remove redundant 'flush_workqueue()' calls Christophe JAILLET
2021-10-16 4:31 ` Christoph Hellwig
2021-10-16 22:11 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®