* Re: [PATCH] media: ccs: complement the return check of pm_runtime_get_if_active()
[not found] <tencent_101DAE60627DF40AE031220023065E77EB07@qq.com>
@ 2021-11-19 10:56 ` Sakari Ailus
0 siblings, 0 replies; only message in thread
From: Sakari Ailus @ 2021-11-19 10:56 UTC (permalink / raw)
To: Peiwei Hu; +Cc: mchehab, linux-media, linux-kernel
Hi Peiwei,
On Fri, Nov 19, 2021 at 01:34:26PM +0800, Peiwei Hu wrote:
> pm_runtime_get_if_active() can return the negative value. The
> operator ! confuses the negative one with positive situation.
>
> Signed-off-by: Peiwei Hu <jlu.hpw@foxmail.com>
> ---
> drivers/media/i2c/ccs/ccs-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c
> index 5363f3bcafe3..84e810451dd4 100644
> --- a/drivers/media/i2c/ccs/ccs-core.c
> +++ b/drivers/media/i2c/ccs/ccs-core.c
> @@ -670,7 +670,7 @@ static int ccs_set_ctrl(struct v4l2_ctrl *ctrl)
> break;
> }
>
> - pm_status = pm_runtime_get_if_active(&client->dev, true);
> + pm_status = pm_runtime_get_if_active(&client->dev, true) > 0;
> if (!pm_status)
> return 0;
This is intentional --- pm_runtime_get_if_active() returns an error if
runtime PM is disabled.
--
Regards,
Sakari Ailus
^ permalink raw reply [flat|nested] only message in thread