[PATCH] linux: regulator: pca9450.h: Correct register masks for LDOs

[PATCH] linux: regulator: pca9450.h: Correct register masks for LDOs

[André Werner]

[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]


 From 6dda12150785665ddd1059d53aa22bf902bfe4aa Mon Sep 17 00:00:00 2001
From: Andre Werner <andre.werner@systec-electronic.com>
Date: Mon, 22 Nov 2021 15:40:17 +0100
Subject: [PATCH] linux: regulator: pca9450.h: Correct register masks for LDOs

Within the defines of the register masks for LDO3 and LDO4,
the most significant bit was missing. The datasheet said
the range is 4:0 bits. Thus, the output voltage cannot be
set above 1.7V for each.

Signed-off-by: Andre Werner <andre.werner@systec-electronic.com>
---
  include/linux/regulator/pca9450.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/regulator/pca9450.h  
b/include/linux/regulator/pca9450.h
index 71902f41c919..0c3edff6bdff 100644
--- a/include/linux/regulator/pca9450.h
+++ b/include/linux/regulator/pca9450.h
@@ -196,11 +196,11 @@ enum {

  /* PCA9450_REG_LDO3_VOLT bits */
  #define LDO3_EN_MASK                   0xC0
-#define LDO3OUT_MASK                   0x0F
+#define LDO3OUT_MASK                   0x1F

  /* PCA9450_REG_LDO4_VOLT bits */
  #define LDO4_EN_MASK                   0xC0
-#define LDO4OUT_MASK                   0x0F
+#define LDO4OUT_MASK                   0x1F

  /* PCA9450_REG_LDO5_VOLT bits */
  #define LDO5L_EN_MASK                  0xC0
-- 
2.31.1


[-- Attachment #2: PGP Public Key --]
[-- Type: application/pgp-keys, Size: 1263 bytes --]

Re: [PATCH] regulator: pca9450.h: Correct register masks for LDOs

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

On Mon, Dec 13, 2021 at 08:23:19AM +0100, André Werner wrote:
> Within the defines of the register masks for LDO3 and LDO4,
> the most significant bit was missing. The datasheet said
> the range is 4:0 bits. Thus, the output voltage cannot be
> set above 1.7V for each.

This doesn't apply against current code, please check and resend.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] regulator: pca9450.h: Correct register masks for LDOs

[André Werner]

[-- Attachment #1: Type: text/plain, Size: 1676 bytes --]


Quoting Mark Brown <broonie@kernel.org>:

> On Mon, Dec 13, 2021 at 08:23:19AM +0100, André Werner wrote:
>> Within the defines of the register masks for LDO3 and LDO4,
>> the most significant bit was missing. The datasheet said
>> the range is 4:0 bits. Thus, the output voltage cannot be
>> set above 1.7V for each.
>
> This doesn't apply against current code, please check and resend.

 From ade25a42e56c341073fc4b35e8096d01522b9046 Mon Sep 17 00:00:00 2001
From: Andre Werner <andre.werner@systec-electronic.com>
Date: Tue, 14 Dec 2021 08:41:14 +0100
Subject: [PATCH] linux: regulator: pca9450.h: Correct register masks for LDOs

Within the defines of the register masks for LDO3 and LDO4,
the most significant bit was missing. The datasheet said
the range is 4:0 bits. Thus, the output voltage cannot be
set above 1.7V for each.

Signed-off-by: Andre Werner <andre.werner@systec-electronic.com>
---
  include/linux/regulator/pca9450.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/regulator/pca9450.h  
b/include/linux/regulator/pca9450.h
index 71902f41c919..0c3edff6bdff 100644
--- a/include/linux/regulator/pca9450.h
+++ b/include/linux/regulator/pca9450.h
@@ -196,11 +196,11 @@ enum {

  /* PCA9450_REG_LDO3_VOLT bits */
  #define LDO3_EN_MASK                   0xC0
-#define LDO3OUT_MASK                   0x0F
+#define LDO3OUT_MASK                   0x1F

  /* PCA9450_REG_LDO4_VOLT bits */
  #define LDO4_EN_MASK                   0xC0
-#define LDO4OUT_MASK                   0x0F
+#define LDO4OUT_MASK                   0x1F

  /* PCA9450_REG_LDO5_VOLT bits */
  #define LDO5L_EN_MASK                  0xC0
-- 
2.31.1




[-- Attachment #2: PGP Public Key --]
[-- Type: application/pgp-keys, Size: 1263 bytes --]

Re: [PATCH] regulator: pca9450.h: Correct register masks for LDOs

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 960 bytes --]

On Tue, Dec 14, 2021 at 01:35:55PM +0100, André Werner wrote:
> 
> Quoting Mark Brown <broonie@kernel.org>:
> 
> > On Mon, Dec 13, 2021 at 08:23:19AM +0100, André Werner wrote:
> > > Within the defines of the register masks for LDO3 and LDO4,
> > > the most significant bit was missing. The datasheet said
> > > the range is 4:0 bits. Thus, the output voltage cannot be
> > > set above 1.7V for each.
> > 
> > This doesn't apply against current code, please check and resend.
> 
> From ade25a42e56c341073fc4b35e8096d01522b9046 Mon Sep 17 00:00:00 2001
> From: Andre Werner <andre.werner@systec-electronic.com>
> Date: Tue, 14 Dec 2021 08:41:14 +0100
> Subject: [PATCH] linux: regulator: pca9450.h: Correct register masks for LDOs

Please follow the patch submission process documented in
submitting-patches.rst - send patches in the documented format as
separate mails, not buried in the middle of a reply in the middle of
another thread.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]