* Re: Re: Re: [PATCH v3] serial: pch_uart: potential dereference of null pointer
@ 2021-12-16 15:41 Jiasheng Jiang
2021-12-16 16:14 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Jiasheng Jiang @ 2021-12-16 15:41 UTC (permalink / raw)
To: gregkh, jirislaby; +Cc: linux-serial, linux-kernel, Jiasheng Jiang
On Thu, Dec 16, 2021 at 11:24:36PM +0800, Greg KH wrote:
> Did you run the kernel before your change and then after your change to
> ensure that the failure you saw before your change is now properly
> fixed?
>
> How did you test this?
Thank you for your answer. But I haven't run it yet.
And in fact I don't know how to trigger the alloc failure.
I just find the other place like eni_init_one() in `drivers/atm/eni.c`
check the return value of the dma_alloc_coherent().
So that's possible to alloc failure.
Therefore, in order to avoid the dereference of the null pointer, it might
be better to deal with it.
Sincerely thanks,
jiasheng jiang
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Re: Re: [PATCH v3] serial: pch_uart: potential dereference of null pointer
2021-12-16 15:41 Re: Re: [PATCH v3] serial: pch_uart: potential dereference of null pointer Jiasheng Jiang
@ 2021-12-16 16:14 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-12-16 16:14 UTC (permalink / raw)
To: Jiasheng Jiang; +Cc: jirislaby, linux-serial, linux-kernel
On Thu, Dec 16, 2021 at 11:41:13PM +0800, Jiasheng Jiang wrote:
> On Thu, Dec 16, 2021 at 11:24:36PM +0800, Greg KH wrote:
> > Did you run the kernel before your change and then after your change to
> > ensure that the failure you saw before your change is now properly
> > fixed?
> >
> > How did you test this?
>
> Thank you for your answer. But I haven't run it yet.
> And in fact I don't know how to trigger the alloc failure.
Then perhaps this change is not needed?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-16 16:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-16 15:41 Re: Re: [PATCH v3] serial: pch_uart: potential dereference of null pointer Jiasheng Jiang
2021-12-16 16:14 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®