mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Len Brown <lenb@kernel.org>
Cc: John Stultz <john.stultz@linaro.org>,
	Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>,
	Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
	rafael.j.wysocki@intel.com, linux-usb@vger.kernel.org,
	YongQin Liu <yongqin.liu@linaro.org>
Subject: Re: [Bug][5.17-rc0] Between commits daadb3bd0e8d and 455e73a07f6e, the kernel stops loading on my devices.
Date: Tue, 25 Jan 2022 10:43:30 +0200	[thread overview]
Message-ID: <Ye+4MpCFeWScLBEr@kuha.fi.intel.com> (raw)
In-Reply-To: <CAJvTdKnMKdQ6KJe63phZ87kJz2SjeQoNTHqajSfv4RJo6+Y6jw@mail.gmail.com>

On Mon, Jan 24, 2022 at 06:00:24PM -0500, Len Brown wrote:
> Tested-by: Len Brown <len.brown@intelcom>
> 
> The typec_link_ports crash goes away w/ the 2nd patch.
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=215529

That patch was already sent out:
https://lore.kernel.org/linux-usb/20220124090228.41396-3-heikki.krogerus@linux.intel.com/

thanks,

> On Fri, Jan 21, 2022 at 4:33 PM John Stultz <john.stultz@linaro.org> wrote:
> >
> > On Thu, Jan 20, 2022 at 3:27 AM Heikki Krogerus
> > <heikki.krogerus@linux.intel.com> wrote:
> > > On Tue, Jan 18, 2022 at 03:12:10PM +0200, Heikki Krogerus wrote:
> > > > I can reproduce this one by simply not creating the component list in
> > > > the code. That function - component_master_add_with_match() - can't
> > > > handle situation where the list is empty. I'll prepare the fix.
> > >
> > > I'm again attaching the proposed fix, just to see if it also gets
> > > corrupted. Can you test does it fix this issue?
> > > You need to apply it on top of the previous one.
> >
> > We've been hitting the null pointer crash from
> > component_master_add_with_match() regression as well on the hikey960
> > board.
> >
> > The patch you attached resolves the issue. It would be great to see it
> > merged upstream soon!
> >
> > Tested-by: John Stultz <john.stultz@linaro.org>
> >
> > thanks
> > -john
> 
> -- 
> Len Brown, Intel Open Source Technology Center

-- 
heikki

      reply	other threads:[~2022-01-25  8:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-17  0:49 Mikhail Gavrilov
2022-01-17  8:58 ` Heikki Krogerus
     [not found]   ` <CABXGCsO5PYBuZ11YR16NLLa0H07Jom1JQhWHFuETfotfBfzkMw@mail.gmail.com>
2022-01-17 11:19     ` Heikki Krogerus
2022-01-17 11:52       ` Mikhail Gavrilov
2022-01-17 12:21         ` Heikki Krogerus
2022-01-18 11:26           ` Mikhail Gavrilov
2022-01-18 13:12             ` Heikki Krogerus
2022-01-18 13:33               ` Heikki Krogerus
2022-01-18 14:09                 ` Mikhail Gavrilov
2022-01-21 21:33                 ` John Stultz
2022-01-24 23:00                   ` Len Brown
2022-01-25  8:43                     ` Heikki Krogerus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ye+4MpCFeWScLBEr@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=john.stultz@linaro.org \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mikhail.v.gavrilov@gmail.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=yongqin.liu@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome