mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
Cc: Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
	rafael.j.wysocki@intel.com, linux-usb@vger.kernel.org
Subject: Re: [Bug][5.17-rc0] Between commits daadb3bd0e8d and 455e73a07f6e, the kernel stops loading on my devices.
Date: Mon, 17 Jan 2022 13:19:13 +0200	[thread overview]
Message-ID: <YeVQsRp7aDMcQKs7@kuha.fi.intel.com> (raw)
In-Reply-To: <CABXGCsO5PYBuZ11YR16NLLa0H07Jom1JQhWHFuETfotfBfzkMw@mail.gmail.com>

On Mon, Jan 17, 2022 at 03:46:44PM +0500, Mikhail Gavrilov wrote:
> On Mon, 17 Jan 2022 at 13:58, Heikki Krogerus
> <heikki.krogerus@linux.intel.com> wrote:
> >
> > Hi Mikhail,
> >
> > Thank you for bisecting the problem.
> >
> > The code assumes currently that every USB Type-C port has an ACPI
> > device node defined for it in the ACPI tables, but it looks like we
> > can't make that assumption. Could you send me the acpidump?
> >
> > I'm attaching a test patch where I check the Type-C port ACPI nodes.
> > Let me know it that fixes the problem.
> >
> 
> Hi Heikki,
> Unfonitaly I can't test patch because it applicable to actual code base.
> 
> $ cat 0001-usb-typec-Test-fix.patch | git apply -v
> Checking patch drivers/usb/typec/port-mapper.c...
> error: while searching for:
> {?
>     struct each_port_arg arg = { .port = con, .match = NULL };?
> ?
>     bus_for_each_dev(&acpi_bus_type, NULL, &arg, typec_port_match);?
> ?
>     /*?
> 
> error: patch failed: drivers/usb/typec/port-mapper.c:56
> error: drivers/usb/typec/port-mapper.c: patch does not apply

I don't know which tree you are working on top of, but the patch
applies just fine on top of Linus' latest master branch:
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

> I attached acpidump files from my workstation and laptop.

Thanks. I can see UCSI in your laptop dump, but not in the workstation
dump. The laptop has the device nodes also for the ports as expected.

Which machine is failing?

Br,

-- 
heikki

  parent reply	other threads:[~2022-01-17 11:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-17  0:49 Mikhail Gavrilov
2022-01-17  8:58 ` Heikki Krogerus
     [not found]   ` <CABXGCsO5PYBuZ11YR16NLLa0H07Jom1JQhWHFuETfotfBfzkMw@mail.gmail.com>
2022-01-17 11:19     ` Heikki Krogerus [this message]
2022-01-17 11:52       ` Mikhail Gavrilov
2022-01-17 12:21         ` Heikki Krogerus
2022-01-18 11:26           ` Mikhail Gavrilov
2022-01-18 13:12             ` Heikki Krogerus
2022-01-18 13:33               ` Heikki Krogerus
2022-01-18 14:09                 ` Mikhail Gavrilov
2022-01-21 21:33                 ` John Stultz
2022-01-24 23:00                   ` Len Brown
2022-01-25  8:43                     ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YeVQsRp7aDMcQKs7@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mikhail.v.gavrilov@gmail.com \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®