From: Michal Hocko <mhocko@suse.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
David Hildenbrand <david@redhat.com>,
Alexey Makhalov <amakhalov@vmware.com>,
Dennis Zhou <dennis@kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Oscar Salvador <osalvador@suse.de>, Tejun Heo <tj@kernel.org>,
Christoph Lameter <cl@linux.com>, Nico Pache <npache@redhat.com>,
Wei Yang <richard.weiyang@gmail.com>,
Rafael Aquini <raquini@redhat.com>
Subject: Re: [PATCH 4/6] mm, memory_hotplug: reorganize new pgdat initialization
Date: Thu, 27 Jan 2022 15:45:30 +0100 [thread overview]
Message-ID: <YfKwCqxMkN+Slz11@dhcp22.suse.cz> (raw)
In-Reply-To: <YfKgq116n7vLRIa7@kernel.org>
On Thu 27-01-22 15:39:55, Mike Rapoport wrote:
> On Thu, Jan 27, 2022 at 09:53:03AM +0100, Michal Hocko wrote:
[...]
> > + pgdat->nr_zones = 0;
> > + pgdat->kswapd_order = 0;
> > + pgdat->kswapd_highest_zoneidx = 0;
> > + pgdat->node_start_pfn = 0;
> > + for_each_online_cpu(cpu) {
> > + struct per_cpu_nodestat *p;
> > +
> > + p = per_cpu_ptr(pgdat->per_cpu_nodestats, cpu);
> > + memset(p, 0, sizeof(*p));
> > + }
>
> It seems to me that most of this is already done by free_area_init_node()
> at boot time anyway. Do I miss something?
As already replied to David I really didn't want to change the existing
logic.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2022-01-27 14:45 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 8:52 [PATCH 0/6] mm, memory_hotplug: handle unitialized numa node gracefully Michal Hocko
2022-01-27 8:53 ` [PATCH 1/6] mm, memory_hotplug: make arch_alloc_nodedata independent on CONFIG_MEMORY_HOTPLUG Michal Hocko
2022-01-27 12:27 ` David Hildenbrand
2022-01-27 13:36 ` Mike Rapoport
2022-01-28 6:18 ` Oscar Salvador
2022-02-01 2:13 ` Wei Yang
2022-01-27 8:53 ` [PATCH 2/6] mm: handle uninitialized numa nodes gracefully Michal Hocko
2022-01-27 12:41 ` David Hildenbrand
2022-01-27 14:50 ` Michal Hocko
2022-01-27 13:37 ` Mike Rapoport
2022-01-27 14:47 ` Michal Hocko
2022-01-27 15:04 ` Mike Rapoport
2022-02-01 2:41 ` Wei Yang
2022-02-01 9:54 ` Michal Hocko
2022-02-03 0:21 ` Wei Yang
2022-02-03 7:23 ` Mike Rapoport
2022-02-03 8:27 ` David Hildenbrand
2022-02-03 9:08 ` Mike Rapoport
2022-02-03 9:11 ` David Hildenbrand
2022-02-03 9:19 ` Michal Hocko
2022-02-03 9:21 ` David Hildenbrand
2022-02-03 8:39 ` Michal Hocko
2022-02-04 22:54 ` Andrew Morton
2022-01-28 6:27 ` Oscar Salvador
2022-01-31 10:34 ` Michal Hocko
2022-01-27 8:53 ` [PATCH 3/6] mm, memory_hotplug: drop arch_free_nodedata Michal Hocko
2022-01-27 12:42 ` David Hildenbrand
2022-01-27 13:37 ` Mike Rapoport
2022-01-28 6:29 ` Oscar Salvador
2022-02-01 2:41 ` Wei Yang
2022-01-27 8:53 ` [PATCH 4/6] mm, memory_hotplug: reorganize new pgdat initialization Michal Hocko
2022-01-27 12:46 ` David Hildenbrand
2022-01-27 14:44 ` Michal Hocko
2022-02-17 10:40 ` Oscar Salvador
2022-01-27 13:39 ` Mike Rapoport
2022-01-27 14:45 ` Michal Hocko [this message]
2022-01-28 10:51 ` Oscar Salvador
2022-02-01 2:42 ` Wei Yang
2022-01-27 8:53 ` [PATCH 5/6] mm: make free_area_init_node aware of memory less nodes Michal Hocko
2022-01-27 12:47 ` David Hildenbrand
2022-01-27 13:34 ` Mike Rapoport
2022-01-28 10:59 ` Oscar Salvador
2022-02-01 2:43 ` Wei Yang
2022-01-27 8:53 ` [PATCH 6/6] memcg: do not tweak node in alloc_mem_cgroup_per_node_info Michal Hocko
2022-01-27 12:50 ` David Hildenbrand
2022-01-28 11:01 ` Oscar Salvador
2022-02-01 2:45 ` Wei Yang
2022-02-01 9:51 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfKwCqxMkN+Slz11@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=amakhalov@vmware.com \
--cc=cl@linux.com \
--cc=david@redhat.com \
--cc=dennis@kernel.org \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npache@redhat.com \
--cc=osalvador@suse.de \
--cc=raquini@redhat.com \
--cc=richard.weiyang@gmail.com \
--cc=rppt@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®