Re: [PATCH] Fixed stylegude error in drivers/staging/rtl8712 by removing un-needed commented out lines

Re: [PATCH] Fixed stylegude error in drivers/staging/rtl8712 by removing un-needed commented out lines

[Greg KH]

On Tue, Feb 08, 2022 at 07:39:59PM +0530, Ankit Kumar Pandey wrote:
> Volatile keyword was left commented out as it was probably used during
> development but was not needed in final build.

Are you sure?  Doesn't it convey some meaning here that needs to be
verified before you remove it?

> And this was causing styleguide error, so I have removed this and there
> for this patch reduces minor styleguide warnings to 0

You can not mix coding style fixes like my bot told you :(

Also the subject line for this change is very odd, look at others for
this same file to see examples of what to do:

$ git log --oneline drivers/staging/rtl8712/rtl871x_pwrctrl.h | head -n 5
9be550ee4391 staging: rtl8712: get rid of flush_scheduled_work
c75afdaf2e53 staging: rtl8712: remove extra blank lines
7c93fdf090df staging: rtl8712: r8712_register_cmd_alive(): Change return values
e24c1f8658c9 staging: rtl8712: add SPDX identifiers
b355da4c7cfb Staging: rtl8712: rtl871x_pwrctrl.h - style fix

thanks,

greg k-h