From: Peter Zijlstra <peterz@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Borislav Petkov <bp@suse.de>,
Tadeusz Struk <tadeusz.struk@linaro.org>, x86-ml <x86@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
zhangqiao22@huawei.com, tj@kernel.org, dietmar.eggemann@arm.com
Subject: Re: [GIT PULL] sched/urgent for 5.17-rc4
Date: Mon, 14 Feb 2022 09:45:22 +0100 [thread overview]
Message-ID: <YgoWoh6pIzlsQx6d@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAHk-=wiHUWHHcPLCvyXQKf2wbL3L1SOQSGVuCdf-py6QZGnuqQ@mail.gmail.com>
On Sun, Feb 13, 2022 at 10:02:22AM -0800, Linus Torvalds wrote:
> On Sun, Feb 13, 2022 at 4:37 AM Borislav Petkov <bp@suse.de> wrote:
> >
> > Tadeusz Struk (1):
> > sched/fair: Fix fault in reweight_entity
>
> I've pulled this, but this really smells bad to me.
>
> If set_load_weight() can see a process that hasn't even had the
> runqueue pointer set yet, then what keeps *others* from the same
> thing?
Urgh, I think you're right, the moment we enter the pidhash and become
visible we should be complete. That means the previous commit
(4ef0c5c6b5ba) is buggered... Let me try and make sense of all that
cgroup stuff again :-(
next prev parent reply other threads:[~2022-02-14 8:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-13 12:37 Borislav Petkov
2022-02-13 18:02 ` Linus Torvalds
2022-02-14 8:45 ` Peter Zijlstra [this message]
2022-02-14 9:16 ` Peter Zijlstra
2022-02-14 19:17 ` Tejun Heo
2022-02-14 19:35 ` Peter Zijlstra
2022-02-14 19:46 ` Tejun Heo
2022-02-17 8:51 ` [PATCH] sched: Fix yet more sched_fork() races Peter Zijlstra
2022-02-17 10:50 ` Dietmar Eggemann
2022-02-17 12:08 ` Zhang Qiao
2022-02-17 17:33 ` Tadeusz Struk
2022-02-18 6:18 ` Zhang Qiao
2022-02-19 10:14 ` [tip: sched/urgent] " tip-bot2 for Peter Zijlstra
2022-02-13 18:04 ` [GIT PULL] sched/urgent for 5.17-rc4 pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgoWoh6pIzlsQx6d@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@suse.de \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tadeusz.struk@linaro.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=zhangqiao22@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®