mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Borislav Petkov <bp@suse.de>,
	Tadeusz Struk <tadeusz.struk@linaro.org>, x86-ml <x86@kernel.org>,
	lkml <linux-kernel@vger.kernel.org>,
	zhangqiao22@huawei.com, dietmar.eggemann@arm.com
Subject: Re: [GIT PULL] sched/urgent for 5.17-rc4
Date: Mon, 14 Feb 2022 09:46:15 -1000	[thread overview]
Message-ID: <Ygqxh09H4QbtRpuE@slm.duckdns.org> (raw)
In-Reply-To: <YgqvGuQUF1BdpAl0@hirez.programming.kicks-ass.net>

On Mon, Feb 14, 2022 at 08:35:54PM +0100, Peter Zijlstra wrote:
> So there's two things that need doing; the re-cloning of the task_group
> thing, but also calling of __set_task_cpu() which sets up the proper
> runqueue links.
> 
> The first is CGroup only, and *could* in theory be done in ->can_fork(),
> but the second needs to be done unconditionally, and it doesn't make
> much sense to split this up.
> 
> I actually tried, but it made the patch bigger/uglier -- but maybe I
> didn't try hard enough.

If there needs to be a separate call anyway, it prolly is better to keep
them together. It'd just be nice to mention why cpu is different in this
regard in a comment.

Thanks.

-- 
tejun

  reply	other threads:[~2022-02-14 19:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-13 12:37 Borislav Petkov
2022-02-13 18:02 ` Linus Torvalds
2022-02-14  8:45   ` Peter Zijlstra
2022-02-14  9:16     ` Peter Zijlstra
2022-02-14 19:17       ` Tejun Heo
2022-02-14 19:35         ` Peter Zijlstra
2022-02-14 19:46           ` Tejun Heo [this message]
2022-02-17  8:51       ` [PATCH] sched: Fix yet more sched_fork() races Peter Zijlstra
2022-02-17 10:50         ` Dietmar Eggemann
2022-02-17 12:08         ` Zhang Qiao
2022-02-17 17:33         ` Tadeusz Struk
2022-02-18  6:18         ` Zhang Qiao
2022-02-19 10:14       ` [tip: sched/urgent] " tip-bot2 for Peter Zijlstra
2022-02-13 18:04 ` [GIT PULL] sched/urgent for 5.17-rc4 pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ygqxh09H4QbtRpuE@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=bp@suse.de \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tadeusz.struk@linaro.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    --cc=zhangqiao22@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®