* Re: [PATCH] soc: qcom: qmi: Use min() instead of doing it manually
[not found] <CAFo17PjBtoWcrQyxe-Twowf+_5FJ3_OOMjtv950VBR7NocWfhg@mail.gmail.com>
@ 2022-03-01 1:53 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2022-03-01 1:53 UTC (permalink / raw)
To: lotte bai; +Cc: agross, linux-arm-msm, linux-kernel
On Mon 28 Feb 19:36 CST 2022, lotte bai wrote:
> Fix following coccicheck warning:
> drivers/soc/qcom/qmi_interface.c:773:12-13: WARNING opportunity for min()
>
Thanks for the patch Haowen.
> Signed-off-by: Haowen Bai <baihaowen88@gmail.com>
> ---
> drivers/soc/qcom/qmi_interface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/qmi_interface.c
> b/drivers/soc/qcom/qmi_interface.c
> index c8c4c73..3337a70 100644
> --- a/drivers/soc/qcom/qmi_interface.c
> +++ b/drivers/soc/qcom/qmi_interface.c
> @@ -770,7 +770,7 @@ static ssize_t qmi_send_message(struct qmi_handle *qmi,
>
> kfree(msg);
>
> - return ret < 0 ? ret : 0;
> + return min(ret, 0);
The code isn't trying to say "return the minimum of ret and 0", it says
"if ret is negative return that, otherwise return 0".
Mathematically this happens to be the same, but for me as reader of the
code they have different meaning.
Regards,
Bjorn
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] soc: qcom: qmi: Use min() instead of doing it manually
@ 2022-02-25 8:00 Haowen Bai
0 siblings, 0 replies; 2+ messages in thread
From: Haowen Bai @ 2022-02-25 8:00 UTC (permalink / raw)
To: agross, bjorn.andersson; +Cc: linux-arm-msm, linux-kernel, Haowen Bai
Fix following coccicheck warning:
drivers/soc/qcom/qmi_interface.c:773:12-13: WARNING opportunity for min()
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
drivers/soc/qcom/qmi_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/qmi_interface.c b/drivers/soc/qcom/qmi_interface.c
index c8c4c73..3337a70 100644
--- a/drivers/soc/qcom/qmi_interface.c
+++ b/drivers/soc/qcom/qmi_interface.c
@@ -770,7 +770,7 @@ static ssize_t qmi_send_message(struct qmi_handle *qmi,
kfree(msg);
- return ret < 0 ? ret : 0;
+ return min(ret, 0);
}
/**
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-01 1:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CAFo17PjBtoWcrQyxe-Twowf+_5FJ3_OOMjtv950VBR7NocWfhg@mail.gmail.com>
2022-03-01 1:53 ` [PATCH] soc: qcom: qmi: Use min() instead of doing it manually Bjorn Andersson
2022-02-25 8:00 Haowen Bai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®