From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, Ben Segall <bsegall@google.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>, Mel Gorman <mgorman@suse.de>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH] sched: Make preempt_enable_no_resched() behave like preempt_enable() on PREEMPT_RT
Date: Tue, 1 Mar 2022 21:23:49 +0100 [thread overview]
Message-ID: <Yh6A1a6yBfPW8AMk@linutronix.de> (raw)
In-Reply-To: <20220301201432.GL11184@worktop.programming.kicks-ass.net>
On 2022-03-01 21:14:32 [+0100], Peter Zijlstra wrote:
> Ignoring !x86 for a moment:
>
> arch/x86/mm/kmmio.c: preempt_enable_no_resched();
> arch/x86/mm/kmmio.c: preempt_enable_no_resched();
> include/linux/preempt.h:#define sched_preempt_enable_no_resched() \
> include/linux/preempt.h:#define preempt_enable_no_resched() sched_preempt_enable_no_resched()
> include/linux/preempt.h:#define preempt_enable_no_resched_notrace() \
> include/linux/preempt.h:#define sched_preempt_enable_no_resched() barrier()
> include/linux/preempt.h:#define preempt_enable_no_resched() barrier()
> include/linux/preempt.h:#define preempt_enable_no_resched_notrace() barrier()
> include/linux/preempt.h:#undef sched_preempt_enable_no_resched
> include/linux/preempt.h:#undef preempt_enable_no_resched
> include/linux/preempt.h:#undef preempt_enable_no_resched_notrace
> kernel/sched/core.c: preempt_enable_no_resched();
> kernel/sched/core.c: preempt_enable_no_resched();
> kernel/sched/core.c: sched_preempt_enable_no_resched();
> kernel/sched/core.c: sched_preempt_enable_no_resched();
> kernel/sched/core.c: sched_preempt_enable_no_resched();
> kernel/sched/core.c: preempt_enable_no_resched_notrace();
> kernel/sched/core.c: preempt_enable_no_resched_notrace();
> kernel/sched/core.c: sched_preempt_enable_no_resched();
> kernel/sched/core.c: sched_preempt_enable_no_resched();
> kernel/signal.c: preempt_enable_no_resched();
> kernel/smpboot.c: preempt_enable_no_resched();
> lib/smp_processor_id.c: preempt_enable_no_resched_notrace();
>
>
> Surely we can audit that... At a glance the proposed patch does more
> harm than good. Only the kmmio case looks obviousl fail, but then IIRC
> kmmio had worse problems.
I was looking at the same before posting it. The majority of it
disappeared over time after certain someone made it worthless for
modules. So I'm dropping it then.
Does it make sense to keep sched_preempt_enable_no_resched() or should I
move everything to preempt_enable_no_resched()?
Sebastian
prev parent reply other threads:[~2022-03-01 20:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 18:30 Sebastian Andrzej Siewior
2022-03-01 20:14 ` Peter Zijlstra
2022-03-01 20:23 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh6A1a6yBfPW8AMk@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome