* [PATCH] crypto: rockchip: ECB does not need IV
@ 2022-02-11 12:16 Corentin Labbe
2022-02-23 2:44 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Corentin Labbe @ 2022-02-11 12:16 UTC (permalink / raw)
To: herbert, heiko
Cc: linux-arm-kernel, linux-crypto, linux-kernel, linux-rockchip,
Corentin Labbe
When loading rockchip crypto module, testmgr complains that ivsize of ecb-des3-ede-rk
is not the same than generic implementation.
In fact ECB does not use an IV.
Fixes: ce0183cb6464b ("crypto: rockchip - switch to skcipher API")
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
drivers/crypto/rockchip/rk3288_crypto_skcipher.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c b/drivers/crypto/rockchip/rk3288_crypto_skcipher.c
index 1cece1a7d3f0..5bbf0d2722e1 100644
--- a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c
+++ b/drivers/crypto/rockchip/rk3288_crypto_skcipher.c
@@ -506,7 +506,6 @@ struct rk_crypto_tmp rk_ecb_des3_ede_alg = {
.exit = rk_ablk_exit_tfm,
.min_keysize = DES3_EDE_KEY_SIZE,
.max_keysize = DES3_EDE_KEY_SIZE,
- .ivsize = DES_BLOCK_SIZE,
.setkey = rk_tdes_setkey,
.encrypt = rk_des3_ede_ecb_encrypt,
.decrypt = rk_des3_ede_ecb_decrypt,
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] crypto: rockchip: ECB does not need IV
2022-02-11 12:16 [PATCH] crypto: rockchip: ECB does not need IV Corentin Labbe
@ 2022-02-23 2:44 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2022-02-23 2:44 UTC (permalink / raw)
To: Corentin Labbe
Cc: heiko, linux-arm-kernel, linux-crypto, linux-kernel, linux-rockchip
On Fri, Feb 11, 2022 at 12:16:17PM +0000, Corentin Labbe wrote:
> When loading rockchip crypto module, testmgr complains that ivsize of ecb-des3-ede-rk
> is not the same than generic implementation.
> In fact ECB does not use an IV.
>
> Fixes: ce0183cb6464b ("crypto: rockchip - switch to skcipher API")
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> drivers/crypto/rockchip/rk3288_crypto_skcipher.c | 1 -
> 1 file changed, 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-23 2:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-11 12:16 [PATCH] crypto: rockchip: ECB does not need IV Corentin Labbe
2022-02-23 2:44 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®