From: Mark Brown <broonie@kernel.org>
To: Vincent Whitchurch <vincent.whitchurch@axis.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
kernel@axis.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: virtual: add devicetree support
Date: Wed, 23 Feb 2022 14:23:16 +0000 [thread overview]
Message-ID: <YhZDVGC7dPiisnI+@sirena.org.uk> (raw)
In-Reply-To: <20220218110604.1329024-1-vincent.whitchurch@axis.com>
[-- Attachment #1: Type: text/plain, Size: 773 bytes --]
On Fri, Feb 18, 2022 at 12:06:03PM +0100, Vincent Whitchurch wrote:
> The reg-virt-consumer is very useful for development and testing of
> regulator drivers since it allows voltages and modes to be set from
> userspace. However, it currently requires platform data so it cannot be
> used on modern platforms. Add support for probing it from the
> devicetree to remedy this.
Meh, you can add a bit of code on module_init() to register a platform
device or something.
> Since this driver is only meant for testing and is a purely software
> construct, no binding documentation is added.
That's not going to stop anyone. We should at the very least be
printing very loud warnings if anyone tries to intantiate this.
> + if (!reg_id)
> + reg_id = "default";
> +
Oh?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-02-23 14:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 11:06 Vincent Whitchurch
2022-02-23 14:23 ` Mark Brown [this message]
2022-02-28 15:50 ` Vincent Whitchurch
2022-02-28 15:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhZDVGC7dPiisnI+@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@axis.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®