From: Mark Brown <broonie@kernel.org>
To: Vincent Whitchurch <vincent.whitchurch@axis.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
kernel@axis.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: virtual: add devicetree support
Date: Mon, 28 Feb 2022 15:55:32 +0000 [thread overview]
Message-ID: <YhzwdBP4OJe+bdyw@sirena.org.uk> (raw)
In-Reply-To: <20220228155027.GA16152@axis.com>
[-- Attachment #1: Type: text/plain, Size: 1443 bytes --]
On Mon, Feb 28, 2022 at 04:50:27PM +0100, Vincent Whitchurch wrote:
> On Wed, Feb 23, 2022 at 02:23:16PM +0000, Mark Brown wrote:
> > That's not going to stop anyone. We should at the very least be
> > printing very loud warnings if anyone tries to intantiate this.
> I can add a warning. Maybe something like this, following the style of
> kernel/trace/trace.c?
> pr_warn("**********************************************************\n");
> pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n");
> pr_warn("** **\n");
> pr_warn("** regulator-virtual-consumer is only for testing and **\n");
> pr_warn("** debugging. Do not use it in a production kernel. **\n");
> pr_warn("** **\n");
> pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n");
> pr_warn("**********************************************************\n");
Something along those lines would do it, yes.
> > > + if (!reg_id)
> > > + reg_id = "default";
> > > +
> > Oh?
> As you know, this results in looking for the regulator phandle in a
> property named "default-supply". I wasn't sure what supply name to use
> for this virtual client. Getting the name from another property seemed
> unnecessary. Would you prefer that, or would you suggest some other
> name than "default"?
I'd suggest adding a comment.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-02-28 15:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 11:06 Vincent Whitchurch
2022-02-23 14:23 ` Mark Brown
2022-02-28 15:50 ` Vincent Whitchurch
2022-02-28 15:55 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhzwdBP4OJe+bdyw@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@axis.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®