* [PATCH] mfd: hi6421-spmi-pmic: fix platform_get_irq.cocci warning
@ 2022-03-02 6:56 Yihao Han
2022-03-18 12:39 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Yihao Han @ 2022-03-02 6:56 UTC (permalink / raw)
To: Arnd Bergmann, Greg Kroah-Hartman, linux-kernel; +Cc: kernel, Yihao Han
Remove dev_err() messages after platform_get_irq*() failures.
platform_get_irq() already prints an error.
Generated by: scripts/coccinelle/api/platform_get_irq.cocci
Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
drivers/misc/hi6421v600-irq.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/misc/hi6421v600-irq.c b/drivers/misc/hi6421v600-irq.c
index 1c763796cf1f..babb85364aa9 100644
--- a/drivers/misc/hi6421v600-irq.c
+++ b/drivers/misc/hi6421v600-irq.c
@@ -244,10 +244,8 @@ static int hi6421v600_irq_probe(struct platform_device *pdev)
pmic_pdev = container_of(pmic_dev, struct platform_device, dev);
priv->irq = platform_get_irq(pmic_pdev, 0);
- if (priv->irq < 0) {
- dev_err(dev, "Error %d when getting IRQs\n", priv->irq);
+ if (priv->irq < 0)
return priv->irq;
- }
platform_set_drvdata(pdev, priv);
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: hi6421-spmi-pmic: fix platform_get_irq.cocci warning
2022-03-02 6:56 [PATCH] mfd: hi6421-spmi-pmic: fix platform_get_irq.cocci warning Yihao Han
@ 2022-03-18 12:39 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2022-03-18 12:39 UTC (permalink / raw)
To: Yihao Han; +Cc: Arnd Bergmann, linux-kernel, kernel
On Tue, Mar 01, 2022 at 10:56:29PM -0800, Yihao Han wrote:
> Remove dev_err() messages after platform_get_irq*() failures.
> platform_get_irq() already prints an error.
>
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
>
> Signed-off-by: Yihao Han <hanyihao@vivo.com>
> ---
> drivers/misc/hi6421v600-irq.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Subject line is wrong :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-18 12:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-02 6:56 [PATCH] mfd: hi6421-spmi-pmic: fix platform_get_irq.cocci warning Yihao Han
2022-03-18 12:39 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®