mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [device-mapper-dm:dm-5.19 132/132] drivers/md/dm.c:1542:18: error: 'result' undeclared
@ 2022-03-23 22:57 kernel test robot
  2022-03-23 23:07 ` Mike Snitzer
  0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2022-03-23 22:57 UTC (permalink / raw)
  To: Mike Snitzer; +Cc: kbuild-all, dm-devel, linux-kernel

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git dm-5.19
head:   7f8ac95a6464b895e3d2b6175f7ee64a4c10fcfe
commit: 7f8ac95a6464b895e3d2b6175f7ee64a4c10fcfe [132/132] dm: push error handling down to __split_and_process_bio
config: s390-buildonly-randconfig-r005-20220323 (https://download.01.org/0day-ci/archive/20220324/202203240638.crXQjFY5-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?id=7f8ac95a6464b895e3d2b6175f7ee64a4c10fcfe
        git remote add device-mapper-dm https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git
        git fetch --no-tags device-mapper-dm dm-5.19
        git checkout 7f8ac95a6464b895e3d2b6175f7ee64a4c10fcfe
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=s390 SHELL=/bin/bash drivers/md/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/md/dm.c: In function '__process_abnormal_io':
>> drivers/md/dm.c:1542:18: error: 'result' undeclared (first use in this function)
    1542 |                 *result = BLK_STS_NOTSUPP;
         |                  ^~~~~~
   drivers/md/dm.c:1542:18: note: each undeclared identifier is reported only once for each function it appears in


vim +/result +1542 drivers/md/dm.c

  1508	
  1509	static bool __process_abnormal_io(struct clone_info *ci, struct dm_target *ti,
  1510					  blk_status_t *status)
  1511	{
  1512		unsigned num_bios;
  1513	
  1514		if (!is_abnormal_io(ci->bio))
  1515			return false;
  1516	
  1517		num_bios = 0;
  1518		switch (bio_op(ci->bio)) {
  1519		case REQ_OP_DISCARD:
  1520			num_bios = ti->num_discard_bios;
  1521			break;
  1522		case REQ_OP_SECURE_ERASE:
  1523			num_bios = ti->num_secure_erase_bios;
  1524			break;
  1525		case REQ_OP_WRITE_SAME:
  1526			num_bios = ti->num_write_same_bios;
  1527			break;
  1528		case REQ_OP_WRITE_ZEROES:
  1529			num_bios = ti->num_write_zeroes_bios;
  1530			break;
  1531		default:
  1532			return false;
  1533		}
  1534	
  1535		/*
  1536		 * Even though the device advertised support for this type of
  1537		 * request, that does not mean every target supports it, and
  1538		 * reconfiguration might also have changed that since the
  1539		 * check was performed.
  1540		 */
  1541		if (!num_bios)
> 1542			*result = BLK_STS_NOTSUPP;
  1543		else {
  1544			__send_changing_extent_only(ci, ti, num_bios);
  1545			*result = BLK_STS_OK;
  1546		}
  1547		return true;
  1548	}
  1549	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [device-mapper-dm:dm-5.19 132/132] drivers/md/dm.c:1542:18: error: 'result' undeclared
  2022-03-23 22:57 [device-mapper-dm:dm-5.19 132/132] drivers/md/dm.c:1542:18: error: 'result' undeclared kernel test robot
@ 2022-03-23 23:07 ` Mike Snitzer
  2022-03-24  0:31   ` [kbuild-all] " Chen, Rong A
  0 siblings, 1 reply; 3+ messages in thread
From: Mike Snitzer @ 2022-03-23 23:07 UTC (permalink / raw)
  To: kernel test robot; +Cc: Mike Snitzer, kbuild-all, dm-devel, linux-kernel

On Wed, Mar 23 2022 at  6:57P -0400,
kernel test robot <lkp@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git dm-5.19
> head:   7f8ac95a6464b895e3d2b6175f7ee64a4c10fcfe
> commit: 7f8ac95a6464b895e3d2b6175f7ee64a4c10fcfe [132/132] dm: push error handling down to __split_and_process_bio
> config: s390-buildonly-randconfig-r005-20220323 (https://download.01.org/0day-ci/archive/20220324/202203240638.crXQjFY5-lkp@intel.com/config)
> compiler: s390-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?id=7f8ac95a6464b895e3d2b6175f7ee64a4c10fcfe
>         git remote add device-mapper-dm https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git
>         git fetch --no-tags device-mapper-dm dm-5.19
>         git checkout 7f8ac95a6464b895e3d2b6175f7ee64a4c10fcfe
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=s390 SHELL=/bin/bash drivers/md/
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/md/dm.c: In function '__process_abnormal_io':
> >> drivers/md/dm.c:1542:18: error: 'result' undeclared (first use in this function)
>     1542 |                 *result = BLK_STS_NOTSUPP;
>          |                  ^~~~~~
>    drivers/md/dm.c:1542:18: note: each undeclared identifier is reported only once for each function it appears in
> 

Yeah, I pushed this too soon, fixed now.

But why are you even testing this branch? I didn't include dm-5.19 in
linux-next yet.

Given that it seems strange for the bot to just pick up some branch,
and then spam LKML, dm-devel, etc like it found a meaningful problem.

Mike


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [kbuild-all] Re: [device-mapper-dm:dm-5.19 132/132] drivers/md/dm.c:1542:18: error: 'result' undeclared
  2022-03-23 23:07 ` Mike Snitzer
@ 2022-03-24  0:31   ` Chen, Rong A
  0 siblings, 0 replies; 3+ messages in thread
From: Chen, Rong A @ 2022-03-24  0:31 UTC (permalink / raw)
  To: Mike Snitzer, kernel test robot
  Cc: Mike Snitzer, kbuild-all, dm-devel, linux-kernel



On 3/24/2022 7:07 AM, Mike Snitzer wrote:
> On Wed, Mar 23 2022 at  6:57P -0400,
> kernel test robot <lkp@intel.com> wrote:
> 
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git dm-5.19
>> head:   7f8ac95a6464b895e3d2b6175f7ee64a4c10fcfe
>> commit: 7f8ac95a6464b895e3d2b6175f7ee64a4c10fcfe [132/132] dm: push error handling down to __split_and_process_bio
>> config: s390-buildonly-randconfig-r005-20220323 (https://download.01.org/0day-ci/archive/20220324/202203240638.crXQjFY5-lkp@intel.com/config)
>> compiler: s390-linux-gcc (GCC) 11.2.0
>> reproduce (this is a W=1 build):
>>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>          chmod +x ~/bin/make.cross
>>          # https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?id=7f8ac95a6464b895e3d2b6175f7ee64a4c10fcfe
>>          git remote add device-mapper-dm https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git
>>          git fetch --no-tags device-mapper-dm dm-5.19
>>          git checkout 7f8ac95a6464b895e3d2b6175f7ee64a4c10fcfe
>>          # save the config file to linux build tree
>>          mkdir build_dir
>>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=s390 SHELL=/bin/bash drivers/md/
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
>>     drivers/md/dm.c: In function '__process_abnormal_io':
>>>> drivers/md/dm.c:1542:18: error: 'result' undeclared (first use in this function)
>>      1542 |                 *result = BLK_STS_NOTSUPP;
>>           |                  ^~~~~~
>>     drivers/md/dm.c:1542:18: note: each undeclared identifier is reported only once for each function it appears in
>>
> 
> Yeah, I pushed this too soon, fixed now.
> 
> But why are you even testing this branch? I didn't include dm-5.19 in
> linux-next yet.

Hi Mike,

The bot picks up all branches to test, do you want it to only test few 
branches?


> 
> Given that it seems strange for the bot to just pick up some branch,
> and then spam LKML, dm-devel, etc like it found a meaningful problem.

we also support sending reports privately, do you want this way?

Best Regards,
Rong Chen

> 
> Mike
> _______________________________________________
> kbuild-all mailing list -- kbuild-all@lists.01.org
> To unsubscribe send an email to kbuild-all-leave@lists.01.org
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-03-24  0:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-23 22:57 [device-mapper-dm:dm-5.19 132/132] drivers/md/dm.c:1542:18: error: 'result' undeclared kernel test robot
2022-03-23 23:07 ` Mike Snitzer
2022-03-24  0:31   ` [kbuild-all] " Chen, Rong A

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®