From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Detlev Casanova <detlev.casanova@collabora.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH v1 1/1] regulator/rpi-panel-attiny: Get rid of duplicate of_node assignment
Date: Wed, 6 Apr 2022 16:21:42 +0300 [thread overview]
Message-ID: <Yk2T5rjR6Qn0nEFx@smile.fi.intel.com> (raw)
In-Reply-To: <Yk2R5el6fUm4FQo5@sirena.org.uk>
On Wed, Apr 06, 2022 at 02:13:09PM +0100, Mark Brown wrote:
> On Wed, Apr 06, 2022 at 04:01:41PM +0300, Andy Shevchenko wrote:
> > On Fri, Mar 25, 2022 at 08:45:08PM +0200, Andy Shevchenko wrote:
> > > GPIO library does copy the of_node from the parent device of
> > > the GPIO chip, there is no need to repeat this in the individual
> > > drivers. Remove these assignment all at once.
> > >
> > > For the details one may look into the of_gpio_dev_init() implementation.
> >
> > Any comments on this? Can it be applied now?
>
> Please don't send content free pings and please allow a reasonable time
> for review. People get busy, go on holiday, attend conferences and so
> on so unless there is some reason for urgency (like critical bug fixes)
> please allow at least a couple of weeks for review. If there have been
> review comments then people may be waiting for those to be addressed.
Oops, indeed, it has been only 12 days passed with no nothing :-)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-04-06 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 18:45 Andy Shevchenko
2022-04-06 13:01 ` Andy Shevchenko
2022-04-06 13:13 ` Mark Brown
2022-04-06 13:21 ` Andy Shevchenko [this message]
2022-04-07 12:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yk2T5rjR6Qn0nEFx@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=dave.stevenson@raspberrypi.com \
--cc=detlev.casanova@collabora.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®