* [PATCH] staging: r8188eu: Fix misspelling in comment
@ 2022-03-30 6:23 Haowen Bai
2022-03-30 6:39 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Haowen Bai @ 2022-03-30 6:23 UTC (permalink / raw)
To: Larry Finger, Phillip Potter, Greg Kroah-Hartman
Cc: Haowen Bai, linux-staging, linux-kernel
This patch fixes some spelling typo in error message reported by checkpatch.pl
WARNING: 'cacluated' may be misspelled - perhaps 'calculated'?
WARNING: 'cacluated' may be misspelled - perhaps 'calculated'?
WARNING: 'writting' may be misspelled - perhaps 'writing'?
WARNING: 'defualt' may be misspelled - perhaps 'default'?
WARNING: 'Caculate' may be misspelled - perhaps 'Calculate'?
WARNING: 'accordign' may be misspelled - perhaps 'according'?
WARNING: 'regster' may be misspelled - perhaps 'register'?
WARNING: 'Wirte' may be misspelled - perhaps 'Write'?
WARNING: 'Tranceiver' may be misspelled - perhaps 'Transceiver'?
WARNING: 'Tranceiver' may be misspelled - perhaps 'Transceiver'?
WARNING: 'Tranceiver' may be misspelled - perhaps 'Transceiver'?
WARNING: 'Tranceiver' may be misspelled - perhaps 'Transceiver'?
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 2 +-
drivers/staging/r8188eu/hal/odm_HWConfig.c | 4 ++--
drivers/staging/r8188eu/hal/odm_RTL8188E.c | 2 +-
drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 2 +-
drivers/staging/r8188eu/hal/rtl8188e_phycfg.c | 12 ++++++------
drivers/staging/r8188eu/hal/usb_halinit.c | 2 +-
6 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c b/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c
index b944c80..310b6f5 100644
--- a/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c
+++ b/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c
@@ -69,7 +69,7 @@ void ODM_TxPwrTrackAdjust88E(struct odm_dm_struct *dm_odm, u8 Type,/* 0 = OFDM,
/*-----------------------------------------------------------------------------
* Function: odm_TxPwrTrackSetPwr88E()
*
- * Overview: 88E change all channel tx power accordign to flag.
+ * Overview: 88E change all channel tx power according to flag.
* OFDM & CCK are all different.
*
* Input: NONE
diff --git a/drivers/staging/r8188eu/hal/odm_HWConfig.c b/drivers/staging/r8188eu/hal/odm_HWConfig.c
index 87e9a52..1183e4a 100644
--- a/drivers/staging/r8188eu/hal/odm_HWConfig.c
+++ b/drivers/staging/r8188eu/hal/odm_HWConfig.c
@@ -71,7 +71,7 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct odm_dm_struct *dm_odm,
u8 cck_agc_rpt;
/* (1)Hardware does not provide RSSI for CCK */
- /* (2)PWDB, Average PWDB cacluated by hardware (for rate adaptive) */
+ /* (2)PWDB, Average PWDB calculated by hardware (for rate adaptive) */
cck_highpwr = dm_odm->bCckHighPower;
@@ -170,7 +170,7 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct odm_dm_struct *dm_odm,
/* Get Rx snr value in DB */
dm_odm->PhyDbgInfo.RxSNRdB[i] = (s32)(pPhyStaRpt->path_rxsnr[i] / 2);
}
- /* (2)PWDB, Average PWDB cacluated by hardware (for rate adaptive) */
+ /* (2)PWDB, Average PWDB calculated by hardware (for rate adaptive) */
rx_pwr_all = (((pPhyStaRpt->cck_sig_qual_ofdm_pwdb_all) >> 1) & 0x7f) - 110;
PWDB_ALL = odm_QueryRxPwrPercentage(rx_pwr_all);
diff --git a/drivers/staging/r8188eu/hal/odm_RTL8188E.c b/drivers/staging/r8188eu/hal/odm_RTL8188E.c
index c8a3c52..dd9c829 100644
--- a/drivers/staging/r8188eu/hal/odm_RTL8188E.c
+++ b/drivers/staging/r8188eu/hal/odm_RTL8188E.c
@@ -194,7 +194,7 @@ static void odm_HWAntDiv(struct odm_dm_struct *dm_odm)
for (i = 0; i < ODM_ASSOCIATE_ENTRY_NUM; i++) {
pEntry = dm_odm->pODM_StaInfo[i];
if (IS_STA_VALID(pEntry)) {
- /* 2 Caculate RSSI per Antenna */
+ /* 2 Calculate RSSI per Antenna */
Main_RSSI = (dm_fat_tbl->MainAnt_Cnt[i] != 0) ? (dm_fat_tbl->MainAnt_Sum[i] / dm_fat_tbl->MainAnt_Cnt[i]) : 0;
Aux_RSSI = (dm_fat_tbl->AuxAnt_Cnt[i] != 0) ? (dm_fat_tbl->AuxAnt_Sum[i] / dm_fat_tbl->AuxAnt_Cnt[i]) : 0;
TargetAnt = (Main_RSSI >= Aux_RSSI) ? MAIN_ANT : AUX_ANT;
diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
index 6811be9..2658bac 100644
--- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
+++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
@@ -327,7 +327,7 @@ void rtl8188e_EfusePowerSwitch(struct adapter *pAdapter, u8 PwrState)
if (PwrState) {
rtw_write8(pAdapter, REG_EFUSE_ACCESS, EFUSE_ACCESS_ON);
- /* 1.2V Power: From VDDON with Power Cut(0x0000h[15]), defualt valid */
+ /* 1.2V Power: From VDDON with Power Cut(0x0000h[15]), default valid */
tmpV16 = rtw_read16(pAdapter, REG_SYS_ISO_CTRL);
if (!(tmpV16 & PWC_EV12V)) {
tmpV16 |= PWC_EV12V;
diff --git a/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c
index ea75ff1..3a7437c 100644
--- a/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c
+++ b/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c
@@ -100,7 +100,7 @@ void rtl8188e_PHY_SetBBReg(struct adapter *Adapter, u32 RegAddr, u32 BitMask, u3
/**
* Function: phy_RFSerialRead
*
-* OverView: Read regster from RF chips
+* OverView: Read register from RF chips
*
* Input:
* struct adapter *Adapter,
@@ -369,7 +369,7 @@ phy_InitBBRFRegisterDefinition(
/* RF Interface (Output and) Enable */
pHalData->PHYRegDef.rfintfe = rFPGA0_XA_RFInterfaceOE; /* 16 MSBs if read 32-bit from 0x860 (16-bit for 0x862) */
- /* Addr of LSSI. Wirte RF register by driver */
+ /* Addr of LSSI. Write RF register by driver */
pHalData->PHYRegDef.rf3wireOffset = rFPGA0_XA_LSSIParameter; /* LSSI Parameter */
/* RF parameter */
@@ -378,10 +378,10 @@ phy_InitBBRFRegisterDefinition(
/* Tx AGC Gain Stage (same for all path. Should we remove this?) */
pHalData->PHYRegDef.rfTxGainStage = rFPGA0_TxGainStage; /* Tx gain stage */
- /* Tranceiver A~D HSSI Parameter-1 */
+ /* Transceiver A~D HSSI Parameter-1 */
pHalData->PHYRegDef.rfHSSIPara1 = rFPGA0_XA_HSSIParameter1; /* wire control parameter1 */
- /* Tranceiver A~D HSSI Parameter-2 */
+ /* Transceiver A~D HSSI Parameter-2 */
pHalData->PHYRegDef.rfHSSIPara2 = rFPGA0_XA_HSSIParameter2; /* wire control parameter2 */
/* RF switch Control */
@@ -405,10 +405,10 @@ phy_InitBBRFRegisterDefinition(
/* Tx AFE control 2 */
pHalData->PHYRegDef.rfTxAFE = rOFDM0_XATxAFE;
- /* Tranceiver LSSI Readback SI mode */
+ /* Transceiver LSSI Readback SI mode */
pHalData->PHYRegDef.rfLSSIReadBack = rFPGA0_XA_LSSIReadBack;
- /* Tranceiver LSSI Readback PI mode */
+ /* Transceiver LSSI Readback PI mode */
pHalData->PHYRegDef.rfLSSIReadBackPi = TransceiverA_HSPI_Readback;
}
diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
index a927743..e334c9b 100644
--- a/drivers/staging/r8188eu/hal/usb_halinit.c
+++ b/drivers/staging/r8188eu/hal/usb_halinit.c
@@ -123,7 +123,7 @@ static void _InitQueueReservedPage(struct adapter *Adapter)
if (haldata->OutEpQueueSel & TX_SELE_LQ)
numLQ = 0x1C;
- /* NOTE: This step shall be proceed before writting REG_RQPN. */
+ /* NOTE: This step shall be proceed before writing REG_RQPN. */
if (haldata->OutEpQueueSel & TX_SELE_NQ)
numNQ = 0x1C;
value8 = (u8)_NPQ(numNQ);
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: r8188eu: Fix misspelling in comment
2022-03-30 6:23 [PATCH] staging: r8188eu: Fix misspelling in comment Haowen Bai
@ 2022-03-30 6:39 ` Greg Kroah-Hartman
2022-03-30 7:27 ` [PATCH V2] staging: r8188eu: Fix misspelling in comment "Tranceiver" -> "Transceiver" Haowen Bai
0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2022-03-30 6:39 UTC (permalink / raw)
To: Haowen Bai; +Cc: Larry Finger, Phillip Potter, linux-staging, linux-kernel
On Wed, Mar 30, 2022 at 02:23:33PM +0800, Haowen Bai wrote:
> This patch fixes some spelling typo in error message reported by checkpatch.pl
>
> WARNING: 'cacluated' may be misspelled - perhaps 'calculated'?
> WARNING: 'cacluated' may be misspelled - perhaps 'calculated'?
> WARNING: 'writting' may be misspelled - perhaps 'writing'?
> WARNING: 'defualt' may be misspelled - perhaps 'default'?
> WARNING: 'Caculate' may be misspelled - perhaps 'Calculate'?
> WARNING: 'accordign' may be misspelled - perhaps 'according'?
> WARNING: 'regster' may be misspelled - perhaps 'register'?
> WARNING: 'Wirte' may be misspelled - perhaps 'Write'?
> WARNING: 'Tranceiver' may be misspelled - perhaps 'Transceiver'?
> WARNING: 'Tranceiver' may be misspelled - perhaps 'Transceiver'?
> WARNING: 'Tranceiver' may be misspelled - perhaps 'Transceiver'?
> WARNING: 'Tranceiver' may be misspelled - perhaps 'Transceiver'?
Please break this up into one-patch-per-misspelled-word.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V2] staging: r8188eu: Fix misspelling in comment "Tranceiver" -> "Transceiver"
2022-03-30 6:39 ` Greg Kroah-Hartman
@ 2022-03-30 7:27 ` Haowen Bai
0 siblings, 0 replies; 6+ messages in thread
From: Haowen Bai @ 2022-03-30 7:27 UTC (permalink / raw)
To: Larry Finger, Phillip Potter, Greg Kroah-Hartman
Cc: Haowen Bai, linux-staging, linux-kernel
This patch fixes some spelling typo in error message reported by
checkpatch.pl
WARNING: 'Tranceiver' may be misspelled - perhaps 'Transceiver'?
WARNING: 'Tranceiver' may be misspelled - perhaps 'Transceiver'?
WARNING: 'Tranceiver' may be misspelled - perhaps 'Transceiver'?
WARNING: 'Tranceiver' may be misspelled - perhaps 'Transceiver'?
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
V1->V2: split one-patch-per-misspelled-word; change title;
drivers/staging/r8188eu/hal/rtl8188e_phycfg.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c
index ea75ff1..4864daf 100644
--- a/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c
+++ b/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c
@@ -378,10 +378,10 @@ phy_InitBBRFRegisterDefinition(
/* Tx AGC Gain Stage (same for all path. Should we remove this?) */
pHalData->PHYRegDef.rfTxGainStage = rFPGA0_TxGainStage; /* Tx gain stage */
- /* Tranceiver A~D HSSI Parameter-1 */
+ /* Transceiver A~D HSSI Parameter-1 */
pHalData->PHYRegDef.rfHSSIPara1 = rFPGA0_XA_HSSIParameter1; /* wire control parameter1 */
- /* Tranceiver A~D HSSI Parameter-2 */
+ /* Transceiver A~D HSSI Parameter-2 */
pHalData->PHYRegDef.rfHSSIPara2 = rFPGA0_XA_HSSIParameter2; /* wire control parameter2 */
/* RF switch Control */
@@ -405,10 +405,10 @@ phy_InitBBRFRegisterDefinition(
/* Tx AFE control 2 */
pHalData->PHYRegDef.rfTxAFE = rOFDM0_XATxAFE;
- /* Tranceiver LSSI Readback SI mode */
+ /* Transceiver LSSI Readback SI mode */
pHalData->PHYRegDef.rfLSSIReadBack = rFPGA0_XA_LSSIReadBack;
- /* Tranceiver LSSI Readback PI mode */
+ /* Transceiver LSSI Readback PI mode */
pHalData->PHYRegDef.rfLSSIReadBackPi = TransceiverA_HSPI_Readback;
}
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: r8188eu: Fix misspelling in comment
2022-03-29 14:52 ` Greg KH
@ 2022-03-30 1:42 ` baihaowen
0 siblings, 0 replies; 6+ messages in thread
From: baihaowen @ 2022-03-30 1:42 UTC (permalink / raw)
To: Greg KH
Cc: Larry.Finger, phil, straube.linux, linux, linux-staging, linux-kernel
在 3/29/22 10:52 PM, Greg KH 写道:
> On Mon, Mar 21, 2022 at 10:55:14AM +0800, Haowen Bai wrote:
>> The original error is as below shows:
>>
>> CHECK: 'associcated' may be misspelled - perhaps 'associated'?
>>
>> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
>> ---
>> drivers/staging/r8188eu/core/rtw_ap.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/r8188eu/core/rtw_ap.c b/drivers/staging/r8188eu/core/rtw_ap.c
>> index 1675e2e..e02dd8e 100644
>> --- a/drivers/staging/r8188eu/core/rtw_ap.c
>> +++ b/drivers/staging/r8188eu/core/rtw_ap.c
>> @@ -819,7 +819,7 @@ static int rtw_ht_operation_update(struct adapter *padapter)
>>
>> void associated_clients_update(struct adapter *padapter, u8 updated)
>> {
>> - /* update associcated stations cap. */
>> + /* update associated stations cap. */
>> if (updated) {
>> struct list_head *phead, *plist;
>> struct sta_info *psta = NULL;
>> @@ -972,7 +972,7 @@ void bss_cap_update_on_sta_join(struct adapter *padapter, struct sta_info *psta)
>> update_beacon(padapter, _HT_ADD_INFO_IE_, NULL, true);
>> }
>>
>> - /* update associcated stations cap. */
>> + /* update associated stations cap. */
>> associated_clients_update(padapter, beacon_updated);
>>
>> DBG_88E("%s, updated =%d\n", __func__, beacon_updated);
>> @@ -1036,7 +1036,7 @@ u8 bss_cap_update_on_sta_leave(struct adapter *padapter, struct sta_info *psta)
>> update_beacon(padapter, _HT_ADD_INFO_IE_, NULL, true);
>> }
>>
>> - /* update associcated stations cap. */
>> + /* update associated stations cap. */
>>
>> DBG_88E("%s, updated =%d\n", __func__, beacon_updated);
>>
>> --
>> 2.7.4
>>
>>
> Does not apply to my tree :(
yes, I need to develop on the next branch, but not before.
--
Haowen Bai
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: r8188eu: Fix misspelling in comment
2022-03-21 2:55 [PATCH] staging: r8188eu: Fix misspelling in comment Haowen Bai
@ 2022-03-29 14:52 ` Greg KH
2022-03-30 1:42 ` baihaowen
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2022-03-29 14:52 UTC (permalink / raw)
To: Haowen Bai
Cc: Larry.Finger, phil, straube.linux, linux, linux-staging, linux-kernel
On Mon, Mar 21, 2022 at 10:55:14AM +0800, Haowen Bai wrote:
> The original error is as below shows:
>
> CHECK: 'associcated' may be misspelled - perhaps 'associated'?
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> drivers/staging/r8188eu/core/rtw_ap.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_ap.c b/drivers/staging/r8188eu/core/rtw_ap.c
> index 1675e2e..e02dd8e 100644
> --- a/drivers/staging/r8188eu/core/rtw_ap.c
> +++ b/drivers/staging/r8188eu/core/rtw_ap.c
> @@ -819,7 +819,7 @@ static int rtw_ht_operation_update(struct adapter *padapter)
>
> void associated_clients_update(struct adapter *padapter, u8 updated)
> {
> - /* update associcated stations cap. */
> + /* update associated stations cap. */
> if (updated) {
> struct list_head *phead, *plist;
> struct sta_info *psta = NULL;
> @@ -972,7 +972,7 @@ void bss_cap_update_on_sta_join(struct adapter *padapter, struct sta_info *psta)
> update_beacon(padapter, _HT_ADD_INFO_IE_, NULL, true);
> }
>
> - /* update associcated stations cap. */
> + /* update associated stations cap. */
> associated_clients_update(padapter, beacon_updated);
>
> DBG_88E("%s, updated =%d\n", __func__, beacon_updated);
> @@ -1036,7 +1036,7 @@ u8 bss_cap_update_on_sta_leave(struct adapter *padapter, struct sta_info *psta)
> update_beacon(padapter, _HT_ADD_INFO_IE_, NULL, true);
> }
>
> - /* update associcated stations cap. */
> + /* update associated stations cap. */
>
> DBG_88E("%s, updated =%d\n", __func__, beacon_updated);
>
> --
> 2.7.4
>
>
Does not apply to my tree :(
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] staging: r8188eu: Fix misspelling in comment
@ 2022-03-21 2:55 Haowen Bai
2022-03-29 14:52 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Haowen Bai @ 2022-03-21 2:55 UTC (permalink / raw)
To: Larry.Finger, phil, gregkh, straube.linux, linux
Cc: linux-staging, linux-kernel, Haowen Bai
The original error is as below shows:
CHECK: 'associcated' may be misspelled - perhaps 'associated'?
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
drivers/staging/r8188eu/core/rtw_ap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_ap.c b/drivers/staging/r8188eu/core/rtw_ap.c
index 1675e2e..e02dd8e 100644
--- a/drivers/staging/r8188eu/core/rtw_ap.c
+++ b/drivers/staging/r8188eu/core/rtw_ap.c
@@ -819,7 +819,7 @@ static int rtw_ht_operation_update(struct adapter *padapter)
void associated_clients_update(struct adapter *padapter, u8 updated)
{
- /* update associcated stations cap. */
+ /* update associated stations cap. */
if (updated) {
struct list_head *phead, *plist;
struct sta_info *psta = NULL;
@@ -972,7 +972,7 @@ void bss_cap_update_on_sta_join(struct adapter *padapter, struct sta_info *psta)
update_beacon(padapter, _HT_ADD_INFO_IE_, NULL, true);
}
- /* update associcated stations cap. */
+ /* update associated stations cap. */
associated_clients_update(padapter, beacon_updated);
DBG_88E("%s, updated =%d\n", __func__, beacon_updated);
@@ -1036,7 +1036,7 @@ u8 bss_cap_update_on_sta_leave(struct adapter *padapter, struct sta_info *psta)
update_beacon(padapter, _HT_ADD_INFO_IE_, NULL, true);
}
- /* update associcated stations cap. */
+ /* update associated stations cap. */
DBG_88E("%s, updated =%d\n", __func__, beacon_updated);
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-30 7:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-30 6:23 [PATCH] staging: r8188eu: Fix misspelling in comment Haowen Bai
2022-03-30 6:39 ` Greg Kroah-Hartman
2022-03-30 7:27 ` [PATCH V2] staging: r8188eu: Fix misspelling in comment "Tranceiver" -> "Transceiver" Haowen Bai
-- strict thread matches above, loose matches on Subject: below --
2022-03-21 2:55 [PATCH] staging: r8188eu: Fix misspelling in comment Haowen Bai
2022-03-29 14:52 ` Greg KH
2022-03-30 1:42 ` baihaowen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®