From: Sean Christopherson <seanjc@google.com>
To: cgel.zte@gmail.com
Cc: pbonzini@redhat.com, vkuznets@redhat.com, wanpengli@tencent.com,
jmattson@google.com, joro@8bytes.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, Lv Ruyi <lv.ruyi@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] KVM: x86/mmu: remove unnecessary flush_workqueue()
Date: Fri, 1 Apr 2022 13:59:01 +0000 [thread overview]
Message-ID: <YkcFJZW0r+OQmQwz@google.com> (raw)
In-Reply-To: <20220401083530.2407703-1-lv.ruyi@zte.com.cn>
On Fri, Apr 01, 2022, cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> All work currently pending will be done first by calling destroy_workqueue,
> so there is unnecessary to flush it explicitly.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
Good bot :-)
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> ---
> arch/x86/kvm/mmu/tdp_mmu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/mmu/tdp_mmu.c b/arch/x86/kvm/mmu/tdp_mmu.c
> index a2f9a34a0168..b822677ee3da 100644
> --- a/arch/x86/kvm/mmu/tdp_mmu.c
> +++ b/arch/x86/kvm/mmu/tdp_mmu.c
> @@ -51,7 +51,6 @@ void kvm_mmu_uninit_tdp_mmu(struct kvm *kvm)
> if (!kvm->arch.tdp_mmu_enabled)
> return;
>
> - flush_workqueue(kvm->arch.tdp_mmu_zap_wq);
Might be worth adding a comment calling out that this drains the queue. Either way,
Reviewed-by: Sean Christopherson <seanjc@google.com>
next prev parent reply other threads:[~2022-04-01 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 8:35 cgel.zte
2022-04-01 13:59 ` Sean Christopherson [this message]
2022-04-05 12:12 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkcFJZW0r+OQmQwz@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=cgel.zte@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.ruyi@zte.com.cn \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®