* [PATCH] KVM: x86/mmu: remove unnecessary flush_workqueue()
@ 2022-04-01 8:35 cgel.zte
2022-04-01 13:59 ` Sean Christopherson
2022-04-05 12:12 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: cgel.zte @ 2022-04-01 8:35 UTC (permalink / raw)
To: pbonzini
Cc: seanjc, vkuznets, wanpengli, jmattson, joro, tglx, mingo, bp,
dave.hansen, x86, hpa, kvm, linux-kernel, Lv Ruyi, Zeal Robot
From: Lv Ruyi <lv.ruyi@zte.com.cn>
All work currently pending will be done first by calling destroy_workqueue,
so there is unnecessary to flush it explicitly.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
---
arch/x86/kvm/mmu/tdp_mmu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/kvm/mmu/tdp_mmu.c b/arch/x86/kvm/mmu/tdp_mmu.c
index a2f9a34a0168..b822677ee3da 100644
--- a/arch/x86/kvm/mmu/tdp_mmu.c
+++ b/arch/x86/kvm/mmu/tdp_mmu.c
@@ -51,7 +51,6 @@ void kvm_mmu_uninit_tdp_mmu(struct kvm *kvm)
if (!kvm->arch.tdp_mmu_enabled)
return;
- flush_workqueue(kvm->arch.tdp_mmu_zap_wq);
destroy_workqueue(kvm->arch.tdp_mmu_zap_wq);
WARN_ON(!list_empty(&kvm->arch.tdp_mmu_pages));
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: x86/mmu: remove unnecessary flush_workqueue()
2022-04-01 8:35 [PATCH] KVM: x86/mmu: remove unnecessary flush_workqueue() cgel.zte
@ 2022-04-01 13:59 ` Sean Christopherson
2022-04-05 12:12 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Sean Christopherson @ 2022-04-01 13:59 UTC (permalink / raw)
To: cgel.zte
Cc: pbonzini, vkuznets, wanpengli, jmattson, joro, tglx, mingo, bp,
dave.hansen, x86, hpa, kvm, linux-kernel, Lv Ruyi, Zeal Robot
On Fri, Apr 01, 2022, cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> All work currently pending will be done first by calling destroy_workqueue,
> so there is unnecessary to flush it explicitly.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
Good bot :-)
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> ---
> arch/x86/kvm/mmu/tdp_mmu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/mmu/tdp_mmu.c b/arch/x86/kvm/mmu/tdp_mmu.c
> index a2f9a34a0168..b822677ee3da 100644
> --- a/arch/x86/kvm/mmu/tdp_mmu.c
> +++ b/arch/x86/kvm/mmu/tdp_mmu.c
> @@ -51,7 +51,6 @@ void kvm_mmu_uninit_tdp_mmu(struct kvm *kvm)
> if (!kvm->arch.tdp_mmu_enabled)
> return;
>
> - flush_workqueue(kvm->arch.tdp_mmu_zap_wq);
Might be worth adding a comment calling out that this drains the queue. Either way,
Reviewed-by: Sean Christopherson <seanjc@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: x86/mmu: remove unnecessary flush_workqueue()
2022-04-01 8:35 [PATCH] KVM: x86/mmu: remove unnecessary flush_workqueue() cgel.zte
2022-04-01 13:59 ` Sean Christopherson
@ 2022-04-05 12:12 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2022-04-05 12:12 UTC (permalink / raw)
To: cgel.zte
Cc: pbonzini, seanjc, vkuznets, wanpengli, jmattson, joro, tglx,
mingo, bp, dave.hansen, x86, hpa, kvm, linux-kernel, Lv Ruyi,
Zeal Robot
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-06 1:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-01 8:35 [PATCH] KVM: x86/mmu: remove unnecessary flush_workqueue() cgel.zte
2022-04-01 13:59 ` Sean Christopherson
2022-04-05 12:12 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®