[PATCH 0/3] iwlwifi: Address whitespace coding style errors

[PATCH 0/3] iwlwifi: Address whitespace coding style errors

[Solomon Tan]

This series of three patches addresses the whitespace coding style
errors marked by checkpatch.pl as an "ERROR". In order of sequence,
the following edits are made:
1. Removal of prohibited spaces
2. Addition of required space
3. Replacement of space with tabs as code indent.

Signed-off-by: Solomon Tan <solomonbstoner@protonmail.ch>

[PATCH 1/3] iwlwifi: Remove prohibited spaces

[Solomon Tan]

This patch addresses the error from checkpatch.pl regarding the presence
of prohibited spaces.

Signed-off-by: Solomon Tan <solomonbstoner@protonmail.ch>
---
 drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c | 2 +-
 drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c   | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c b/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c
index 9040da3dcce3..c11088fecc16 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c
@@ -81,7 +81,7 @@ static const u16 iwl_nvm_channels[] = {
 	/* 2.4 GHz */
 	1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14,
 	/* 5 GHz */
-	36, 40, 44 , 48, 52, 56, 60, 64,
+	36, 40, 44, 48, 52, 56, 60, 64,
 	100, 104, 108, 112, 116, 120, 124, 128, 132, 136, 140, 144,
 	149, 153, 157, 161, 165
 };
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c b/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c
index 49898fd99594..5e7f2c64937e 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c
@@ -214,9 +214,9 @@ static ssize_t iwl_dbgfs_set_nic_temperature_read(struct file *file,
 	int pos;

 	if (!mvm->temperature_test)
-		pos = scnprintf(buf , sizeof(buf), "disabled\n");
+		pos = scnprintf(buf, sizeof(buf), "disabled\n");
 	else
-		pos = scnprintf(buf , sizeof(buf), "%d\n", mvm->temperature);
+		pos = scnprintf(buf, sizeof(buf), "%d\n", mvm->temperature);

 	return simple_read_from_buffer(user_buf, count, ppos, buf, pos);
 }
@@ -261,7 +261,7 @@ static ssize_t iwl_dbgfs_set_nic_temperature_write(struct iwl_mvm *mvm,
 		mvm->temperature = temperature;
 	}
 	IWL_DEBUG_TEMP(mvm, "%sabling debug set temperature (temp = %d)\n",
-		       mvm->temperature_test ? "En" : "Dis" ,
+		       mvm->temperature_test ? "En" : "Dis",
 		       mvm->temperature);
 	/* handle the temperature change */
 	iwl_mvm_tt_handler(mvm);
@@ -291,7 +291,7 @@ static ssize_t iwl_dbgfs_nic_temp_read(struct file *file,
 	if (ret)
 		return -EIO;

-	pos = scnprintf(buf , sizeof(buf), "%d\n", temp);
+	pos = scnprintf(buf, sizeof(buf), "%d\n", temp);

 	return simple_read_from_buffer(user_buf, count, ppos, buf, pos);
 }
--
2.35.3

[PATCH 2/3] iwlwifi: Add required space before open '('

[Solomon Tan]

This patch addresses the error from checkpatch.pl that a space is
required before an open parenthesis.

Signed-off-by: Solomon Tan <solomonbstoner@protonmail.ch>
---
 drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
index e842816134f1..bae270893eac 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
@@ -1016,7 +1016,7 @@ int iwl_mvm_ppag_send_cmd(struct iwl_mvm *mvm)

 	ret = iwl_read_ppag_table(&mvm->fwrt, &cmd, &cmd_size);
 	/* Not supporting PPAG table is a valid scenario */
-	if(ret < 0)
+	if (ret < 0)
 		return 0;

 	IWL_DEBUG_RADIO(mvm, "Sending PER_PLATFORM_ANT_GAIN_CMD\n");
--
2.35.3

Re: [PATCH 0/3] iwlwifi: Address whitespace coding style errors

[Greg KH]

On Tue, Apr 19, 2022 at 01:14:20AM +0000, Solomon Tan wrote:
> This series of three patches addresses the whitespace coding style
> errors marked by checkpatch.pl as an "ERROR". In order of sequence,
> the following edits are made:
> 1. Removal of prohibited spaces
> 2. Addition of required space
> 3. Replacement of space with tabs as code indent.
> 
> Signed-off-by: Solomon Tan <solomonbstoner@protonmail.ch>
> 

No need to ever sign off on a 0/X email.

Also, not all of these were threaded properly, and are you sure that
coding style "fixes" like these are welcome for this part of the kernel?
I recommend starting out in drivers/staging/ first to learn the process
before going anywhere else.

And finally, why cc: me at all?  I am not a wireless developer :)

good luck!

greg k-h