From: Alan Stern <stern@rowland.harvard.edu>
To: Evan Green <evgreen@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Mathias Nyman <mathias.nyman@intel.com>,
Rajat Jain <rajatja@chromium.org>,
Bjorn Helgaas <bhelgaas@google.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Youngjin Jang <yj84.jang@samsung.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 2/2] USB: hcd-pci: Fully suspend across freeze/thaw cycle
Date: Tue, 19 Apr 2022 10:43:02 -0400 [thread overview]
Message-ID: <Yl7KdjrrUrqMkzq8@rowland.harvard.edu> (raw)
In-Reply-To: <20220418135819.v2.2.I8226c7fdae88329ef70957b96a39b346c69a914e@changeid>
On Mon, Apr 18, 2022 at 02:00:46PM -0700, Evan Green wrote:
> The documentation for the freeze() method says that it "should quiesce
> the device so that it doesn't generate IRQs or DMA". The unspoken
> consequence of not doing this is that MSIs aimed at non-boot CPUs may
> get fully lost if they're sent during the period where the target CPU is
> offline.
>
> The current callbacks for USB HCD do not fully quiesce interrupts,
> specifically on XHCI. Change to use the full suspend/resume flow for
> freeze/thaw to ensure interrupts are fully quiesced. This fixes issues
> where USB devices fail to thaw during hibernation because XHCI misses
> its interrupt and cannot recover.
>
> Signed-off-by: Evan Green <evgreen@chromium.org>
>
> ---
Acked-by: Alan Stern <stern@rowland.harvard.edu>
> Changes in v2:
> - Added the patch modifying the remote wakeup state
That wasn't a change to this patch. No matter.
> - Removed the change to freeze_noirq/thaw_noirq
>
> drivers/usb/core/hcd-pci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/hcd-pci.c
> index 8176bc81a635d6..ae5e6d572376be 100644
> --- a/drivers/usb/core/hcd-pci.c
> +++ b/drivers/usb/core/hcd-pci.c
> @@ -616,10 +616,10 @@ const struct dev_pm_ops usb_hcd_pci_pm_ops = {
> .suspend_noirq = hcd_pci_suspend_noirq,
> .resume_noirq = hcd_pci_resume_noirq,
> .resume = hcd_pci_resume,
> - .freeze = check_root_hub_suspended,
> + .freeze = hcd_pci_suspend,
> .freeze_noirq = check_root_hub_suspended,
> .thaw_noirq = NULL,
> - .thaw = NULL,
> + .thaw = hcd_pci_resume,
> .poweroff = hcd_pci_suspend,
> .poweroff_noirq = hcd_pci_suspend_noirq,
> .restore_noirq = hcd_pci_resume_noirq,
next prev parent reply other threads:[~2022-04-19 14:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 21:00 [PATCH v2 0/2] USB: Quiesce interrupts across pm freeze Evan Green
2022-04-18 21:00 ` [PATCH v2 1/2] USB: core: Disable remote wakeup for freeze/quiesce Evan Green
2022-04-19 14:41 ` Alan Stern
2022-04-20 19:30 ` Evan Green
2022-04-18 21:00 ` [PATCH v2 2/2] USB: hcd-pci: Fully suspend across freeze/thaw cycle Evan Green
2022-04-19 14:43 ` Alan Stern [this message]
2022-04-19 7:05 ` [PATCH v2 0/2] USB: Quiesce interrupts across pm freeze Oliver Neukum
2022-04-19 14:35 ` Alan Stern
2022-04-19 15:51 ` Oliver Neukum
2022-04-19 17:49 ` Alan Stern
2022-04-20 8:47 ` Oliver Neukum
2022-04-20 14:09 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yl7KdjrrUrqMkzq8@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=bhelgaas@google.com \
--cc=evgreen@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rajatja@chromium.org \
--cc=tglx@linutronix.de \
--cc=yj84.jang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®