From: Alan Stern <stern@rowland.harvard.edu>
To: Oliver Neukum <oneukum@suse.com>
Cc: Evan Green <evgreen@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Mathias Nyman <mathias.nyman@intel.com>,
Rajat Jain <rajatja@chromium.org>,
Bjorn Helgaas <bhelgaas@google.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Razvan Heghedus <heghedus.razvan@gmail.com>,
Wei Ming Chen <jj251510319013@gmail.com>,
Youngjin Jang <yj84.jang@samsung.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 0/2] USB: Quiesce interrupts across pm freeze
Date: Wed, 20 Apr 2022 10:09:05 -0400 [thread overview]
Message-ID: <YmAUAVzveDE0oiTt@rowland.harvard.edu> (raw)
In-Reply-To: <95e1bd39-b159-f7a1-f51e-115dd0e60500@suse.com>
On Wed, Apr 20, 2022 at 10:47:27AM +0200, Oliver Neukum wrote:
>
>
> On 19.04.22 19:49, Alan Stern wrote:
> > On Tue, Apr 19, 2022 at 05:51:38PM +0200, Oliver Neukum wrote:
> >>
> >> On 19.04.22 16:35, Alan Stern wrote:
> >>> On Tue, Apr 19, 2022 at 09:05:53AM +0200, Oliver Neukum wrote:
> >>>
> >>>
> >>> The THAW part of suspend-to-hibernation is used only for writing the
> >>> memory image to permanent storage. I doubt that a malfunctioning HID
> >>> device would interfere with this process.
> >>>
> >> True, if and only if all goes well. At the time thaw() has run writing
> >> the image to disk can still fail. In that case the devices will still
> >> be needed.
> > Consider adding a mechanism to usbcore which would allow an interface
> > driver to request that the next time its device is resumed, the core
> > should perform a reset-resume. Would that help?
> >
> >
>
> Strictly speaking no. We already have that in form of the RESET_RESUME
> quirk. The broken devices we are talking about here can do runtime PM
> perfectly fine, if and only if remote wakeup is requested.
> So we need that flag to translate only in freeze()/thaw() resulting in that
> behavior, as opposed to every pair of suspend()/resume()
That was my point. The HID driver can check at suspend time whether or
not remote wakeup will be enabled. If yes, well and good, no changes
are needed. If not, the driver can then request that the following
resume be a runtime-resume.
Another possibility is, as you mentioned before, adding a USB quirk for
devices which require reset-resume whenever they are resumed with wakeup
disabled.
Alan Stern
prev parent reply other threads:[~2022-04-20 14:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 21:00 Evan Green
2022-04-18 21:00 ` [PATCH v2 1/2] USB: core: Disable remote wakeup for freeze/quiesce Evan Green
2022-04-19 14:41 ` Alan Stern
2022-04-20 19:30 ` Evan Green
2022-04-18 21:00 ` [PATCH v2 2/2] USB: hcd-pci: Fully suspend across freeze/thaw cycle Evan Green
2022-04-19 14:43 ` Alan Stern
2022-04-19 7:05 ` [PATCH v2 0/2] USB: Quiesce interrupts across pm freeze Oliver Neukum
2022-04-19 14:35 ` Alan Stern
2022-04-19 15:51 ` Oliver Neukum
2022-04-19 17:49 ` Alan Stern
2022-04-20 8:47 ` Oliver Neukum
2022-04-20 14:09 ` Alan Stern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmAUAVzveDE0oiTt@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=bhelgaas@google.com \
--cc=evgreen@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=heghedus.razvan@gmail.com \
--cc=jj251510319013@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=oneukum@suse.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rajatja@chromium.org \
--cc=tglx@linutronix.de \
--cc=yj84.jang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®