From: Dominik Brodowski <linux@dominikbrodowski.net>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] random: avoid init'ing twice in credit race
Date: Fri, 13 May 2022 08:23:40 +0200 [thread overview]
Message-ID: <Yn35bNS6RlElAGYh@owl.dominikbrodowski.net> (raw)
In-Reply-To: <20220509121409.529788-1-Jason@zx2c4.com>
Am Mon, May 09, 2022 at 02:14:08PM +0200 schrieb Jason A. Donenfeld:
> Since all changes of crng_init now go through credit_init_bits(), we can
> fix a long standing race in which two concurrent callers of
> credit_init_bits() have the new bit count >= some threshold, but are
> doing so with crng_init as a lower threshold, checked outside of a lock,
> resulting in crng_reseed() or similar being called twice.
Sidenote: crng_reseed() did manage quite fine if called twice in short
order.
> In order to fix this, we can use the original cmpxchg value of the bit
> count, and only change crng_init when the bit count transitions from
> below a threshold to meeting the threshold.
>
> Cc: Dominik Brodowski <linux@dominikbrodowski.net>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net>
Thanks,
Dominik
next prev parent reply other threads:[~2022-05-13 6:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 12:14 Jason A. Donenfeld
2022-05-09 12:14 ` [PATCH 2/2] random: move initialization out of reseeding hot path Jason A. Donenfeld
2022-05-13 6:24 ` Dominik Brodowski
2022-05-13 10:21 ` Jason A. Donenfeld
2022-05-13 11:38 ` David Laight
2022-05-13 12:02 ` Jason A. Donenfeld
2022-05-13 12:05 ` [PATCH v2] " Jason A. Donenfeld
2022-05-13 6:23 ` Dominik Brodowski [this message]
2022-05-13 10:23 ` [PATCH 1/2] random: avoid init'ing twice in credit race Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yn35bNS6RlElAGYh@owl.dominikbrodowski.net \
--to=linux@dominikbrodowski.net \
--cc=Jason@zx2c4.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®