From: David Laight <David.Laight@ACULAB.COM>
To: "'Jason A. Donenfeld'" <Jason@zx2c4.com>,
Dominik Brodowski <linux@dominikbrodowski.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] random: move initialization out of reseeding hot path
Date: Fri, 13 May 2022 11:38:23 +0000 [thread overview]
Message-ID: <d0dc54cecff5400d97f877676d7f11b1@AcuMS.aculab.com> (raw)
In-Reply-To: <Yn4xLowv+farg814@zx2c4.com>
From: Jason A. Donenfeld
> Sent: 13 May 2022 11:22
>
> On Fri, May 13, 2022 at 08:24:19AM +0200, Dominik Brodowski wrote:
> > > - if (!crng_ready()) {
> > > - crng_init = CRNG_READY;
> > > - finalize_init = true;
> > > - }
> > > + crng_init = CRNG_READY;
> >
> > Why unconditionally
>
> To avoid a useless branch.
Are you now dirtying a cache line that would
otherwise be clean?
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2022-05-13 11:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 12:14 [PATCH 1/2] random: avoid init'ing twice in credit race Jason A. Donenfeld
2022-05-09 12:14 ` [PATCH 2/2] random: move initialization out of reseeding hot path Jason A. Donenfeld
2022-05-13 6:24 ` Dominik Brodowski
2022-05-13 10:21 ` Jason A. Donenfeld
2022-05-13 11:38 ` David Laight [this message]
2022-05-13 12:02 ` Jason A. Donenfeld
2022-05-13 12:05 ` [PATCH v2] " Jason A. Donenfeld
2022-05-13 6:23 ` [PATCH 1/2] random: avoid init'ing twice in credit race Dominik Brodowski
2022-05-13 10:23 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0dc54cecff5400d97f877676d7f11b1@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=Jason@zx2c4.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®