mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] gpio: fix platform_no_drv_owner.cocci warnings
  2022-05-03 10:00 [asahilinux:bits/110-smc 3/14] drivers/gpio/gpio-macsmc.c:230:3-8: No need to set .owner here. The core will do it kernel test robot
@ 2022-05-03  9:53 ` kernel test robot
  0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2022-05-03  9:53 UTC (permalink / raw)
  To: Hector Martin; +Cc: kbuild-all, linux-kernel

From: kernel test robot <lkp@intel.com>

drivers/gpio/gpio-macsmc.c:230:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/AsahiLinux/linux bits/110-smc
head:   dc3db43287ff1d44b447fff8ed6386b28b339f1c
commit: a29b7d982f099846c00493140bbf5b6aff25c948 [3/14] gpio: Add new gpio-macsmc driver for Apple Macs
:::::: branch date: 26 hours ago
:::::: commit date: 27 hours ago

 drivers/gpio/gpio-macsmc.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/gpio/gpio-macsmc.c
+++ b/drivers/gpio/gpio-macsmc.c
@@ -227,7 +227,6 @@ static int macsmc_gpio_probe(struct plat
 static struct platform_driver macsmc_gpio_driver = {
 	.driver = {
 		.name = "macsmc-gpio",
-		.owner = THIS_MODULE,
 	},
 	.probe = macsmc_gpio_probe,
 };

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [asahilinux:bits/110-smc 3/14] drivers/gpio/gpio-macsmc.c:230:3-8: No need to set .owner here. The core will do it.
@ 2022-05-03 10:00 kernel test robot
  2022-05-03  9:53 ` [PATCH] gpio: fix platform_no_drv_owner.cocci warnings kernel test robot
  0 siblings, 1 reply; 5+ messages in thread
From: kernel test robot @ 2022-05-03 10:00 UTC (permalink / raw)
  To: Hector Martin; +Cc: kbuild-all, linux-kernel

tree:   https://github.com/AsahiLinux/linux bits/110-smc
head:   dc3db43287ff1d44b447fff8ed6386b28b339f1c
commit: a29b7d982f099846c00493140bbf5b6aff25c948 [3/14] gpio: Add new gpio-macsmc driver for Apple Macs
config: arm64-randconfig-c023-20220501 (https://download.01.org/0day-ci/archive/20220503/202205031706.nUBZtKaH-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 11.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cocci warnings: (new ones prefixed by >>)
>> drivers/gpio/gpio-macsmc.c:230:3-8: No need to set .owner here. The core will do it.

Please review and possibly fold the followup patch.

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] gpio: fix platform_no_drv_owner.cocci warnings
  2015-10-07  3:14   ` [PATCH] gpio: fix platform_no_drv_owner.cocci warnings kbuild test robot
@ 2015-10-16 14:47     ` Linus Walleij
  0 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2015-10-16 14:47 UTC (permalink / raw)
  To: kbuild test robot
  Cc: William Breathitt Gray, kbuild-all, Alexandre Courbot,
	linux-kernel, linux-gpio

On Wed, Oct 7, 2015 at 5:14 AM, kbuild test robot <lkp@intel.com> wrote:

> drivers/gpio/gpio-104-idio-16.c:151:3-8: No need to set .owner here. The core will do it.
>
>  Remove .owner field if calls are used which set it automatically
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> CC: William Breathitt Gray <vilhelm.gray@gmail.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

This is confusing, I mix up the mails coming from my pushed git branches
with this new stuff that is obviously checking patches I haven't even applied.
It's better if these kbuild fixes are sent as Re: to the mail ID of the
patch so it appears in the same thread as the offending patch on the
mailing list.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] gpio: fix platform_no_drv_owner.cocci warnings
  2015-10-11 16:41 ` Nicolas Saenz Julienne
@ 2015-10-11 17:12   ` kbuild test robot
  0 siblings, 0 replies; 5+ messages in thread
From: kbuild test robot @ 2015-10-11 17:12 UTC (permalink / raw)
  To: Nicolas Saenz Julienne
  Cc: kbuild-all, linus.walleij, gnurou, linux-gpio, linux-kernel

drivers/gpio/gpio-tps65218.c:153:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Nicolas Saenz Julienne <nicolassaenzj@gmail.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 gpio-tps65218.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/gpio/gpio-tps65218.c
+++ b/drivers/gpio/gpio-tps65218.c
@@ -150,7 +150,6 @@ MODULE_DEVICE_TABLE(of, tps65218_dt_matc
 static struct platform_driver tps65218_gpio_driver = {
 	.driver = {
 		.name = "tps65218-gpio",
-		.owner = THIS_MODULE,
 		.of_match_table = of_match_ptr(tps65218_dt_match)
 	},
 	.probe = tps65218_gpio_probe,

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] gpio: fix platform_no_drv_owner.cocci warnings
  2015-10-07  2:40 ` William Breathitt Gray
@ 2015-10-07  3:14   ` kbuild test robot
  2015-10-16 14:47     ` Linus Walleij
  0 siblings, 1 reply; 5+ messages in thread
From: kbuild test robot @ 2015-10-07  3:14 UTC (permalink / raw)
  To: William Breathitt Gray
  Cc: kbuild-all, linus.walleij, gnurou, linux-kernel, linux-gpio

drivers/gpio/gpio-104-idio-16.c:151:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: William Breathitt Gray <vilhelm.gray@gmail.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 gpio-104-idio-16.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/gpio/gpio-104-idio-16.c
+++ b/drivers/gpio/gpio-104-idio-16.c
@@ -148,7 +148,6 @@ static struct platform_device *a_104_idi
 static struct platform_driver a_104_idio_16_driver = {
 	.driver = {
 		.name = "104-idio-16",
-		.owner = THIS_MODULE
 	},
 	.remove = a_104_idio_16_remove
 };

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-05-03 10:00 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-03 10:00 [asahilinux:bits/110-smc 3/14] drivers/gpio/gpio-macsmc.c:230:3-8: No need to set .owner here. The core will do it kernel test robot
2022-05-03  9:53 ` [PATCH] gpio: fix platform_no_drv_owner.cocci warnings kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2015-10-11 17:12 [PATCH] gpio: add tps65218 gpio driver kbuild test robot
2015-10-11 16:41 ` Nicolas Saenz Julienne
2015-10-11 17:12   ` [PATCH] gpio: fix platform_no_drv_owner.cocci warnings kbuild test robot
2015-10-07  3:14 [PATCH v4] gpio: Add GPIO support for the ACCES 104-IDIO-16 kbuild test robot
2015-10-07  2:40 ` William Breathitt Gray
2015-10-07  3:14   ` [PATCH] gpio: fix platform_no_drv_owner.cocci warnings kbuild test robot
2015-10-16 14:47     ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®