From: Tejun Heo <tj@kernel.org>
To: Imran Khan <imran.f.khan@oracle.com>
Cc: viro@zeniv.linux.org.uk, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] kernfs: Replace global kernfs_open_file_mutex with hashed mutexes.
Date: Thu, 5 May 2022 10:05:51 -1000 [thread overview]
Message-ID: <YnQuH5ijv6bWUKPM@slm.duckdns.org> (raw)
In-Reply-To: <20220428055431.3826852-6-imran.f.khan@oracle.com>
On Thu, Apr 28, 2022 at 03:54:31PM +1000, Imran Khan wrote:
> +static void __init kernfs_mutex_init(void)
> +{
> + int count;
> +
> + for (count = 0; count < NR_KERNFS_LOCKS; count++)
> + mutex_init(&kernfs_locks->open_file_mutex[count]);
> +}
Does this need to be a separate function?
> +static void __init kernfs_lock_init(void)
> +{
> + kernfs_locks = kmalloc(sizeof(struct kernfs_global_locks), GFP_KERNEL);
> + WARN_ON(!kernfs_locks);
> +
> + kernfs_mutex_init();
> +}
> +
> void __init kernfs_init(void)
> {
> kernfs_node_cache = kmem_cache_create("kernfs_node_cache",
Other than that minor nitpick,
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2022-05-05 20:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 5:54 [PATCH 0/5] kernfs: Remove reference counting for kernfs_open_node Imran Khan
2022-04-28 5:54 ` [PATCH 1/5] " Imran Khan
2022-05-05 19:46 ` Tejun Heo
2022-04-28 5:54 ` [PATCH 2/5] kernfs: make ->attr.open RCU protected Imran Khan
2022-05-05 20:01 ` Tejun Heo
2022-05-05 23:12 ` Imran Khan
2022-05-12 17:09 ` Tejun Heo
2022-05-15 16:00 ` Imran Khan
2022-05-16 19:35 ` Tejun Heo
2022-05-17 2:30 ` Imran Khan
2022-05-17 4:21 ` Tejun Heo
2022-04-28 5:54 ` [PATCH 3/5] kernfs: Change kernfs_notify_list to llist Imran Khan
2022-05-05 20:03 ` Tejun Heo
2022-04-28 5:54 ` [PATCH 4/5] kernfs: Introduce interface to access global kernfs_open_file_mutex Imran Khan
2022-05-05 20:04 ` Tejun Heo
2022-04-28 5:54 ` [PATCH 5/5] kernfs: Replace global kernfs_open_file_mutex with hashed mutexes Imran Khan
2022-05-05 20:05 ` Tejun Heo [this message]
2022-05-11 9:58 ` Imran Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnQuH5ijv6bWUKPM@slm.duckdns.org \
--to=tj@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=imran.f.khan@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®