[PATCH] dma-buf: add option text so it can be enabled by users

[PATCH] dma-buf: add option text so it can be enabled by users

[Oleksandr Tymoshenko]

This reverts commit 3b32a592ea6e4 ("dma-buf: drop option text so users
don't select it.") to allow users select DMA_SHARED_BUFFER option
explicitly. This is required for out-of-tree modules that depend on
dma-buf functionality, for instance drivers that rely on Google's Gasket
framework.

On general-purpose Linux systems the option is usually implicitely
enabled in the default kernel config by subsystems that use it but
systems with smaller kernel footprint have to rely on side-effects
from enabling unrelated options to get dma-buf functionality built.

Signed-off-by: Oleksandr Tymoshenko <ovt@google.com>
---
 drivers/base/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
index 6f04b831a5c0..108bf9b38ce6 100644
--- a/drivers/base/Kconfig
+++ b/drivers/base/Kconfig
@@ -198,7 +198,7 @@ config SOC_BUS
 source "drivers/base/regmap/Kconfig"
 
 config DMA_SHARED_BUFFER
-	bool
+	bool "Buffer framework to be shared between drivers"
 	default n
 	select IRQ_WORK
 	help
-- 
2.36.0.464.gb9c8b46e94-goog

Re: [PATCH] dma-buf: add option text so it can be enabled by users

[Greg Kroah-Hartman]

On Thu, May 05, 2022 at 04:50:01AM +0000, Oleksandr Tymoshenko wrote:
> This reverts commit 3b32a592ea6e4 ("dma-buf: drop option text so users
> don't select it.") to allow users select DMA_SHARED_BUFFER option
> explicitly. This is required for out-of-tree modules that depend on
> dma-buf functionality, for instance drivers that rely on Google's Gasket
> framework.

We do not add code to the kernel for out of tree code, sorry.  To do so
would be a total nightmare and maintance impossiblity, and not something
you would want us to do as Linux overall would suffer.

As you well know, the correct solution is to get your code merged
upstream.  I have asked many times to get the gasket code upstream
properly, please do so to resolve problems like this.

thanks,

greg k-h

Re: [PATCH] dma-buf: add option text so it can be enabled by users

[Christoph Hellwig]

On Thu, May 05, 2022 at 04:50:01AM +0000, Oleksandr Tymoshenko wrote:
> This reverts commit 3b32a592ea6e4 ("dma-buf: drop option text so users
> don't select it.") to allow users select DMA_SHARED_BUFFER option
> explicitly. This is required for out-of-tree modules that depend on
> dma-buf functionality, for instance drivers that rely on Google's Gasket
> framework.

Serious, you guys need to stop this crap.  Not offering totally useless
options is a massive improvement for Linux users.  Enabling code for out
of tree crap is not.  Please work with the Andorid ecosystem to make all
this out of tree junk go away instead of making users life painful due
to you not doing your basic work.