mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Wonhyuk Yang <vvghjk1234@gmail.com>,
	Ingo Molnar <mingo@redhat.com>, Baik Song An <bsahn@etri.re.kr>,
	Hong Yeon Kim <kimhy@etri.re.kr>,
	Taeung Song <taeung@reallinux.co.kr>,
	linuxgeek@linuxgeek.io, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] workqueue: Fix type of cpu in trace event
Date: Thu, 26 May 2022 08:55:58 -1000	[thread overview]
Message-ID: <Yo/NPkJW9vnuHBcr@slm.duckdns.org> (raw)
In-Reply-To: <20220524162912.0133006b@gandalf.local.home>

On Tue, May 24, 2022 at 04:29:12PM -0400, Steven Rostedt wrote:
> On Wed,  4 May 2022 11:32:03 +0900
> Wonhyuk Yang <vvghjk1234@gmail.com> wrote:
> 
> > The trace event "workqueue_queue_work" use unsigned int type for
> > req_cpu, cpu. This casue confusing cpu number like below log.
> > 
> > $ cat /sys/kernel/debug/tracing/trace
> > cat-317  [001] ...: workqueue_queue_work: ... req_cpu=8192 cpu=4294967295
> > 
> > So, change unsigned type to signed type in the trace event. After
> > applying this patch, cpu number will be printed as -1 instead of
> > 4294967295 as folllows.
> > 
> 
> I was going through my backlog of pending patches and came across this.
> Note, that trace events are maintained by the subsystem they belong to.
> This change is for workqueues, not tracing (as your subject correctly
> states).
> 
> I Cc'd Tejun here as he maintains this code.

I'll apply it to the wq tree once rc1 drops.

Thanks.

-- 
tejun

  reply	other threads:[~2022-05-26 18:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-04  2:32 Wonhyuk Yang
2022-05-24 20:29 ` Steven Rostedt
2022-05-26 18:55   ` Tejun Heo [this message]
2022-06-07 17:10 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yo/NPkJW9vnuHBcr@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=bsahn@etri.re.kr \
    --cc=kimhy@etri.re.kr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxgeek@linuxgeek.io \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=taeung@reallinux.co.kr \
    --cc=vvghjk1234@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®