mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: daniel watson <ozzloy@challenge-bot.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	Phillip Potter <phil@philpotter.co.uk>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: put spaces after commas
Date: Sun, 12 Jun 2022 06:55:51 +0200	[thread overview]
Message-ID: <YqVx12VsxlH1UaRt@kroah.com> (raw)
In-Reply-To: <20220612040628.6433-1-ozzloy@challenge-bot.com>

On Sat, Jun 11, 2022 at 09:06:28PM -0700, daniel watson wrote:
> From: Daniel Watson <ozzloy@challenge-bot.com>
> 
> conform to kernel style by putting spaces after commas
> this was found by checkpatch
> 
> Signed-off-by: Daniel Watson <ozzloy@challenge-bot.com>
> ---
>  drivers/staging/r8188eu/include/rtw_iol.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/include/rtw_iol.h b/drivers/staging/r8188eu/include/rtw_iol.h
> index fb88ebc1dabb1..b39ecfb75ade0 100644
> --- a/drivers/staging/r8188eu/include/rtw_iol.h
> +++ b/drivers/staging/r8188eu/include/rtw_iol.h
> @@ -50,13 +50,13 @@ int _rtw_IOL_append_WD_cmd(struct xmit_frame *xmit_frame, u16 addr,
>  int _rtw_IOL_append_WRF_cmd(struct xmit_frame *xmit_frame, u8 rf_path,
>  			    u16 addr, u32 value, u32 mask);
>  #define rtw_IOL_append_WB_cmd(xmit_frame, addr, value, mask)		\
> -	_rtw_IOL_append_WB_cmd((xmit_frame), (addr), (value) ,(mask))
> +	_rtw_IOL_append_WB_cmd((xmit_frame), (addr), (value), (mask))
>  #define rtw_IOL_append_WW_cmd(xmit_frame, addr, value, mask)		\
> -	_rtw_IOL_append_WW_cmd((xmit_frame), (addr), (value),(mask))
> +	_rtw_IOL_append_WW_cmd((xmit_frame), (addr), (value), (mask))
>  #define rtw_IOL_append_WD_cmd(xmit_frame, addr, value, mask)		\
>  	_rtw_IOL_append_WD_cmd((xmit_frame), (addr), (value), (mask))
>  #define rtw_IOL_append_WRF_cmd(xmit_frame, rf_path, addr, value, mask)	\
> -	_rtw_IOL_append_WRF_cmd((xmit_frame),(rf_path), (addr), (value), (mask))
> +	_rtw_IOL_append_WRF_cmd((xmit_frame), (rf_path), (addr), (value), (mask))

These #defines shouldn't even be needed, can you just remove them and
rename the _rtw_IOL_append_WRF_cmd() function to be
rtw_IOL_append_WRF_cmd() (and same for the others), as a patch series?

thanks,

greg k-h

      reply	other threads:[~2022-06-12  4:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-12  4:06 daniel watson
2022-06-12  4:55 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YqVx12VsxlH1UaRt@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=ozzloy@challenge-bot.com \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®