* [PATCH] staging: r8188eu: put spaces after commas
@ 2022-06-12 4:06 daniel watson
2022-06-12 4:55 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: daniel watson @ 2022-06-12 4:06 UTC (permalink / raw)
To: Larry Finger, Phillip Potter, Greg Kroah-Hartman, linux-staging,
linux-kernel
Cc: Daniel Watson
From: Daniel Watson <ozzloy@challenge-bot.com>
conform to kernel style by putting spaces after commas
this was found by checkpatch
Signed-off-by: Daniel Watson <ozzloy@challenge-bot.com>
---
drivers/staging/r8188eu/include/rtw_iol.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/r8188eu/include/rtw_iol.h b/drivers/staging/r8188eu/include/rtw_iol.h
index fb88ebc1dabb1..b39ecfb75ade0 100644
--- a/drivers/staging/r8188eu/include/rtw_iol.h
+++ b/drivers/staging/r8188eu/include/rtw_iol.h
@@ -50,13 +50,13 @@ int _rtw_IOL_append_WD_cmd(struct xmit_frame *xmit_frame, u16 addr,
int _rtw_IOL_append_WRF_cmd(struct xmit_frame *xmit_frame, u8 rf_path,
u16 addr, u32 value, u32 mask);
#define rtw_IOL_append_WB_cmd(xmit_frame, addr, value, mask) \
- _rtw_IOL_append_WB_cmd((xmit_frame), (addr), (value) ,(mask))
+ _rtw_IOL_append_WB_cmd((xmit_frame), (addr), (value), (mask))
#define rtw_IOL_append_WW_cmd(xmit_frame, addr, value, mask) \
- _rtw_IOL_append_WW_cmd((xmit_frame), (addr), (value),(mask))
+ _rtw_IOL_append_WW_cmd((xmit_frame), (addr), (value), (mask))
#define rtw_IOL_append_WD_cmd(xmit_frame, addr, value, mask) \
_rtw_IOL_append_WD_cmd((xmit_frame), (addr), (value), (mask))
#define rtw_IOL_append_WRF_cmd(xmit_frame, rf_path, addr, value, mask) \
- _rtw_IOL_append_WRF_cmd((xmit_frame),(rf_path), (addr), (value), (mask))
+ _rtw_IOL_append_WRF_cmd((xmit_frame), (rf_path), (addr), (value), (mask))
u8 rtw_IOL_cmd_boundary_handle(struct xmit_frame *pxmit_frame);
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: r8188eu: put spaces after commas
2022-06-12 4:06 [PATCH] staging: r8188eu: put spaces after commas daniel watson
@ 2022-06-12 4:55 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2022-06-12 4:55 UTC (permalink / raw)
To: daniel watson; +Cc: Larry Finger, Phillip Potter, linux-staging, linux-kernel
On Sat, Jun 11, 2022 at 09:06:28PM -0700, daniel watson wrote:
> From: Daniel Watson <ozzloy@challenge-bot.com>
>
> conform to kernel style by putting spaces after commas
> this was found by checkpatch
>
> Signed-off-by: Daniel Watson <ozzloy@challenge-bot.com>
> ---
> drivers/staging/r8188eu/include/rtw_iol.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/include/rtw_iol.h b/drivers/staging/r8188eu/include/rtw_iol.h
> index fb88ebc1dabb1..b39ecfb75ade0 100644
> --- a/drivers/staging/r8188eu/include/rtw_iol.h
> +++ b/drivers/staging/r8188eu/include/rtw_iol.h
> @@ -50,13 +50,13 @@ int _rtw_IOL_append_WD_cmd(struct xmit_frame *xmit_frame, u16 addr,
> int _rtw_IOL_append_WRF_cmd(struct xmit_frame *xmit_frame, u8 rf_path,
> u16 addr, u32 value, u32 mask);
> #define rtw_IOL_append_WB_cmd(xmit_frame, addr, value, mask) \
> - _rtw_IOL_append_WB_cmd((xmit_frame), (addr), (value) ,(mask))
> + _rtw_IOL_append_WB_cmd((xmit_frame), (addr), (value), (mask))
> #define rtw_IOL_append_WW_cmd(xmit_frame, addr, value, mask) \
> - _rtw_IOL_append_WW_cmd((xmit_frame), (addr), (value),(mask))
> + _rtw_IOL_append_WW_cmd((xmit_frame), (addr), (value), (mask))
> #define rtw_IOL_append_WD_cmd(xmit_frame, addr, value, mask) \
> _rtw_IOL_append_WD_cmd((xmit_frame), (addr), (value), (mask))
> #define rtw_IOL_append_WRF_cmd(xmit_frame, rf_path, addr, value, mask) \
> - _rtw_IOL_append_WRF_cmd((xmit_frame),(rf_path), (addr), (value), (mask))
> + _rtw_IOL_append_WRF_cmd((xmit_frame), (rf_path), (addr), (value), (mask))
These #defines shouldn't even be needed, can you just remove them and
rename the _rtw_IOL_append_WRF_cmd() function to be
rtw_IOL_append_WRF_cmd() (and same for the others), as a patch series?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-12 4:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-12 4:06 [PATCH] staging: r8188eu: put spaces after commas daniel watson
2022-06-12 4:55 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®