From: Tejun Heo <tj@kernel.org>
To: Imran Khan <imran.f.khan@oracle.com>
Cc: viro@zeniv.linux.org.uk, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v4 1/4] kernfs: make ->attr.open RCU protected.
Date: Sun, 12 Jun 2022 16:46:54 -1000 [thread overview]
Message-ID: <YqalHuEB6OjjUosV@slm.duckdns.org> (raw)
In-Reply-To: <6d1c5a49-fc16-5fc7-e527-8cb91ec0d25c@oracle.com>
Hello,
On Mon, Jun 13, 2022 at 12:36:12PM +1000, Imran Khan wrote:
> >> +static struct kernfs_open_node *
> >> +kernfs_check_open_node_protected(struct kernfs_node *kn)
> >> +{
> >> + return rcu_dereference_check(kn->attr.open,
> >> + lockdep_is_held(&kernfs_open_file_mutex));
> >> +}
> >
> > I don't understand why the above is necessary. Whether you're a reader or
> > writer, you can deref the pointer w/ _protected as long as you're holding
> > the lock, right?
>
> As per [1], we should use rcu_dereference_check() for the reader side when we
> are holding the lock.
Hmm.... can you quote the exact phrase that you took the above from?
Thanks.
--
tejun
next prev parent reply other threads:[~2022-06-13 2:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 6:39 [PATCH RESEND v4 0/4] " Imran Khan
2022-06-02 6:39 ` [PATCH RESEND v4 1/4] " Imran Khan
2022-06-12 17:58 ` Tejun Heo
2022-06-13 2:36 ` Imran Khan
2022-06-13 2:46 ` Tejun Heo [this message]
2022-06-13 2:55 ` Imran Khan
2022-06-13 3:09 ` Tejun Heo
2022-06-13 3:56 ` Imran Khan
2022-06-13 17:30 ` Tejun Heo
2022-06-14 2:31 ` Imran Khan
2022-06-02 6:39 ` [PATCH RESEND v4 2/4] kernfs: Change kernfs_notify_list to llist Imran Khan
2022-06-02 6:39 ` [PATCH RESEND v4 3/4] kernfs: Introduce interface to access global kernfs_open_file_mutex Imran Khan
2022-06-02 6:39 ` [PATCH RESEND v4 4/4] kernfs: Replace global kernfs_open_file_mutex with hashed mutexes Imran Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqalHuEB6OjjUosV@slm.duckdns.org \
--to=tj@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=imran.f.khan@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®