[PATCH] usb: remove unnecessary mv_u3d* type casting

[PATCH] usb: remove unnecessary mv_u3d* type casting

[zhoun]

remove unnecessary mv_u3d* type casting.

Signed-off-by: zhoun <zhounan@nfschina.com>
---
 drivers/usb/gadget/udc/mv_u3d_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/mv_u3d_core.c b/drivers/usb/gadget/udc/mv_u3d_core.c
index 598654a3cb41..102278a71307 100644
--- a/drivers/usb/gadget/udc/mv_u3d_core.c
+++ b/drivers/usb/gadget/udc/mv_u3d_core.c
@@ -175,7 +175,7 @@ void mv_u3d_done(struct mv_u3d_ep *ep, struct mv_u3d_req *req, int status)
 	__releases(&ep->udc->lock)
 	__acquires(&ep->udc->lock)
 {
-	struct mv_u3d *u3d = (struct mv_u3d *)ep->u3d;
+	struct mv_u3d *u3d = ep->u3d;
 
 	dev_dbg(u3d->dev, "mv_u3d_done: remove req->queue\n");
 	/* Removed the req from ep queue */
-- 
2.27.0

Re: [PATCH] usb: remove unnecessary mv_u3d* type casting

[Greg KH]

On Fri, Jun 24, 2022 at 04:26:51AM -0400, zhoun wrote:
> remove unnecessary mv_u3d* type casting.

Why do this?  Don't just copy the same text as the subject line.

> 
> Signed-off-by: zhoun <zhounan@nfschina.com>

Please use the name that you use to sign legal documents with.

thanks,

greg k-h

[PATCH v2] usb: remove unnecessary mv_u3d* conversion

[zhoun]

From: Zhou nan <zhounan@nfschina.com>

remove unnecessary mv_u3d* type casting.
After analysis, the two u3d objects have the same type.

Signed-off-by: Zhou nan <zhounan@nfschina.com>
---
 drivers/usb/gadget/udc/mv_u3d_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/mv_u3d_core.c b/drivers/usb/gadget/udc/mv_u3d_core.c
index 598654a3cb41..102278a71307 100644
--- a/drivers/usb/gadget/udc/mv_u3d_core.c
+++ b/drivers/usb/gadget/udc/mv_u3d_core.c
@@ -175,7 +175,7 @@ void mv_u3d_done(struct mv_u3d_ep *ep, struct mv_u3d_req *req, int status)
 	__releases(&ep->udc->lock)
 	__acquires(&ep->udc->lock)
 {
-	struct mv_u3d *u3d = (struct mv_u3d *)ep->u3d;
+	struct mv_u3d *u3d = ep->u3d;
 
 	dev_dbg(u3d->dev, "mv_u3d_done: remove req->queue\n");
 	/* Removed the req from ep queue */
-- 
2.27.0

Re: [PATCH v2] usb: remove unnecessary mv_u3d* conversion

[Greg KH]

On Sun, Jun 26, 2022 at 11:11:08PM -0400, zhoun wrote:
> From: Zhou nan <zhounan@nfschina.com>
> 
> remove unnecessary mv_u3d* type casting.
> After analysis, the two u3d objects have the same type.
> 
> Signed-off-by: Zhou nan <zhounan@nfschina.com>
> ---
>  drivers/usb/gadget/udc/mv_u3d_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/mv_u3d_core.c b/drivers/usb/gadget/udc/mv_u3d_core.c
> index 598654a3cb41..102278a71307 100644
> --- a/drivers/usb/gadget/udc/mv_u3d_core.c
> +++ b/drivers/usb/gadget/udc/mv_u3d_core.c
> @@ -175,7 +175,7 @@ void mv_u3d_done(struct mv_u3d_ep *ep, struct mv_u3d_req *req, int status)
>  	__releases(&ep->udc->lock)
>  	__acquires(&ep->udc->lock)
>  {
> -	struct mv_u3d *u3d = (struct mv_u3d *)ep->u3d;
> +	struct mv_u3d *u3d = ep->u3d;
>  
>  	dev_dbg(u3d->dev, "mv_u3d_done: remove req->queue\n");
>  	/* Removed the req from ep queue */
> -- 
> 2.27.0
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/SubmittingPatches for what needs to be done
  here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot