* [PATCH] lib/bitmap: Make length parameter `len` unsigned
@ 2022-07-07 21:50 Paul Menzel
2022-07-07 22:47 ` Yury Norov
0 siblings, 1 reply; 2+ messages in thread
From: Paul Menzel @ 2022-07-07 21:50 UTC (permalink / raw)
To: Yury Norov, Andy Shevchenko, Rasmus Villemoes; +Cc: Paul Menzel, linux-kernel
The length is non-negative, so make it unsigned, and adapt while
condition accordingly.
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
lib/bitmap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/bitmap.c b/lib/bitmap.c
index b18e31ea6e66..0746beb336df 100644
--- a/lib/bitmap.c
+++ b/lib/bitmap.c
@@ -348,14 +348,14 @@ int __bitmap_weight(const unsigned long *bitmap, unsigned int bits)
}
EXPORT_SYMBOL(__bitmap_weight);
-void __bitmap_set(unsigned long *map, unsigned int start, int len)
+void __bitmap_set(unsigned long *map, unsigned int start, unsigned int len)
{
unsigned long *p = map + BIT_WORD(start);
const unsigned int size = start + len;
int bits_to_set = BITS_PER_LONG - (start % BITS_PER_LONG);
unsigned long mask_to_set = BITMAP_FIRST_WORD_MASK(start);
- while (len - bits_to_set >= 0) {
+ while (len >= bits_to_set) {
*p |= mask_to_set;
len -= bits_to_set;
bits_to_set = BITS_PER_LONG;
--
2.36.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] lib/bitmap: Make length parameter `len` unsigned
2022-07-07 21:50 [PATCH] lib/bitmap: Make length parameter `len` unsigned Paul Menzel
@ 2022-07-07 22:47 ` Yury Norov
0 siblings, 0 replies; 2+ messages in thread
From: Yury Norov @ 2022-07-07 22:47 UTC (permalink / raw)
To: Paul Menzel; +Cc: Andy Shevchenko, Rasmus Villemoes, linux-kernel
On Thu, Jul 07, 2022 at 11:50:52PM +0200, Paul Menzel wrote:
> The length is non-negative, so make it unsigned, and adapt while
> condition accordingly.
>
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Applied, thanks!
> ---
> lib/bitmap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/bitmap.c b/lib/bitmap.c
> index b18e31ea6e66..0746beb336df 100644
> --- a/lib/bitmap.c
> +++ b/lib/bitmap.c
> @@ -348,14 +348,14 @@ int __bitmap_weight(const unsigned long *bitmap, unsigned int bits)
> }
> EXPORT_SYMBOL(__bitmap_weight);
>
> -void __bitmap_set(unsigned long *map, unsigned int start, int len)
> +void __bitmap_set(unsigned long *map, unsigned int start, unsigned int len)
> {
> unsigned long *p = map + BIT_WORD(start);
> const unsigned int size = start + len;
> int bits_to_set = BITS_PER_LONG - (start % BITS_PER_LONG);
> unsigned long mask_to_set = BITMAP_FIRST_WORD_MASK(start);
>
> - while (len - bits_to_set >= 0) {
> + while (len >= bits_to_set) {
> *p |= mask_to_set;
> len -= bits_to_set;
> bits_to_set = BITS_PER_LONG;
> --
> 2.36.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-07 22:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-07 21:50 [PATCH] lib/bitmap: Make length parameter `len` unsigned Paul Menzel
2022-07-07 22:47 ` Yury Norov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®