From: Mark Brown <broonie@kernel.org>
To: Claudiu Beznea <claudiu.beznea@microchip.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/5] ASoC: mchp-spdiftx: remove references to mchp_i2s_caps
Date: Tue, 26 Jul 2022 11:47:31 +0100 [thread overview]
Message-ID: <Yt/GQ80pj2JiRA0a@sirena.org.uk> (raw)
In-Reply-To: <20220725130925.1781791-4-claudiu.beznea@microchip.com>
[-- Attachment #1: Type: text/plain, Size: 738 bytes --]
On Mon, Jul 25, 2022 at 04:09:23PM +0300, Claudiu Beznea wrote:
> @@ -782,11 +780,6 @@ static int mchp_spdiftx_probe(struct platform_device *pdev)
> if (!dev)
> return -ENOMEM;
>
> - /* Get hardware capabilities. */
> - match = of_match_node(mchp_spdiftx_dt_ids, np);
> - if (match)
> - dev->caps = match->data;
> -
This breaks an x86_64 allmodconfig build:
/build/stage/linux/sound/soc/atmel/mchp-spdiftx.c: In function ‘mchp_spdiftx_pro
be’:
/build/stage/linux/sound/soc/atmel/mchp-spdiftx.c:766:29: error: unused variable
‘np’ [-Werror=unused-variable]
766 | struct device_node *np = pdev->dev.of_node;
| ^~
cc1: all warnings being treated as errors
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-07-26 10:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 13:09 [PATCH v2 0/5] ASoC: atmel: one fix and few cleanups Claudiu Beznea
2022-07-25 13:09 ` [PATCH v2 1/5] ASoC: mchp-spdifrx: disable end of block interrupt on failures Claudiu Beznea
2022-07-26 10:45 ` Mark Brown
2022-07-25 13:09 ` [PATCH v2 2/5] ASoC: mchp-spdifrx: use single tab indent for structure Claudiu Beznea
2022-07-25 13:09 ` [PATCH v2 3/5] ASoC: mchp-spdiftx: remove references to mchp_i2s_caps Claudiu Beznea
2022-07-26 10:47 ` Mark Brown [this message]
2022-07-25 13:09 ` [PATCH v2 4/5] ASoC: mchp-spdiftx: return directly ret Claudiu Beznea
2022-07-25 13:09 ` [PATCH v2 5/5] ASoC: mchp-spdiftx: add and remove black line around MODULE_DEVICE_TABLE() Claudiu Beznea
2022-07-26 13:07 ` [PATCH v2 0/5] ASoC: atmel: one fix and few cleanups Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yt/GQ80pj2JiRA0a@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=claudiu.beznea@microchip.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®