* [PATCH v1 1/1] ALSA: isa: Use INVALID_HWIRQ definition
@ 2022-07-15 20:57 Andy Shevchenko
2022-07-16 6:54 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2022-07-15 20:57 UTC (permalink / raw)
To: Takashi Iwai, alsa-devel, linux-kernel
Cc: Jaroslav Kysela, Takashi Iwai, Andy Shevchenko
Use specific definition for invalid IRQ. It makes the
code uniform in respect to the constant used for that.
No functional change intended.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
sound/isa/sscape.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c
index 0bc0025f7c19..9adaf91045e9 100644
--- a/sound/isa/sscape.c
+++ b/sound/isa/sscape.c
@@ -140,8 +140,7 @@ struct soundscape {
unsigned char midi_vol;
};
-#define INVALID_IRQ ((unsigned)-1)
-
+#define INVALID_IRQ ((unsigned)INVALID_HWIRQ)
static inline struct soundscape *get_card_soundscape(struct snd_card *c)
{
--
2.35.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] ALSA: isa: Use INVALID_HWIRQ definition
2022-07-15 20:57 [PATCH v1 1/1] ALSA: isa: Use INVALID_HWIRQ definition Andy Shevchenko
@ 2022-07-16 6:54 ` Takashi Iwai
2022-07-18 19:14 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2022-07-16 6:54 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: alsa-devel, linux-kernel, Jaroslav Kysela, Takashi Iwai
On Fri, 15 Jul 2022 22:57:37 +0200,
Andy Shevchenko wrote:
>
> Use specific definition for invalid IRQ. It makes the
> code uniform in respect to the constant used for that.
> No functional change intended.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> sound/isa/sscape.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c
> index 0bc0025f7c19..9adaf91045e9 100644
> --- a/sound/isa/sscape.c
> +++ b/sound/isa/sscape.c
> @@ -140,8 +140,7 @@ struct soundscape {
> unsigned char midi_vol;
> };
>
> -#define INVALID_IRQ ((unsigned)-1)
> -
> +#define INVALID_IRQ ((unsigned)INVALID_HWIRQ)
>
> static inline struct soundscape *get_card_soundscape(struct snd_card *c)
> {
This seems failing to build on my local tree as is.
We need to include <linux/irq.h> explicitly.
thanks,
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] ALSA: isa: Use INVALID_HWIRQ definition
2022-07-16 6:54 ` Takashi Iwai
@ 2022-07-18 19:14 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2022-07-18 19:14 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel, linux-kernel, Jaroslav Kysela, Takashi Iwai
On Sat, Jul 16, 2022 at 08:54:17AM +0200, Takashi Iwai wrote:
> On Fri, 15 Jul 2022 22:57:37 +0200,
> Andy Shevchenko wrote:
...
> > -#define INVALID_IRQ ((unsigned)-1)
> > -
> > +#define INVALID_IRQ ((unsigned)INVALID_HWIRQ)
>
> This seems failing to build on my local tree as is.
> We need to include <linux/irq.h> explicitly.
As Marc told me this is probably the way to the wrong direction, so, please,
discard this patch anyway.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-18 19:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-15 20:57 [PATCH v1 1/1] ALSA: isa: Use INVALID_HWIRQ definition Andy Shevchenko
2022-07-16 6:54 ` Takashi Iwai
2022-07-18 19:14 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®