[PATCH linux-next] staging: r8188eu: remove redundant variable ret

[PATCH linux-next] staging: r8188eu: remove redundant variable ret

[cgel.zte]

From: Jinpeng Cui <cui.jinpeng2@zte.com.cn>

Return value directly from rtw_set_wpa_ie() instead of
getting value from redundant variable ret.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
---
 drivers/staging/r8188eu/os_dep/ioctl_linux.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
index d6b6021a4250..31a439663626 100644
--- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c
+++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
@@ -1709,11 +1709,9 @@ static int rtw_wx_set_gen_ie(struct net_device *dev,
 			     struct iw_request_info *info,
 			     union iwreq_data *wrqu, char *extra)
 {
-	int ret;
 	struct adapter *padapter = (struct adapter *)rtw_netdev_priv(dev);
 
-	ret = rtw_set_wpa_ie(padapter, extra, wrqu->data.length);
-	return ret;
+	return rtw_set_wpa_ie(padapter, extra, wrqu->data.length);
 }
 
 static int rtw_wx_set_auth(struct net_device *dev,
-- 
2.25.1

Re: [PATCH linux-next] staging: r8188eu: remove redundant variable ret

[Greg KH]

On Wed, Aug 31, 2022 at 02:45:29PM +0000, cgel.zte@gmail.com wrote:
> From: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
> 
> Return value directly from rtw_set_wpa_ie() instead of
> getting value from redundant variable ret.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>

Again, please read the documentation for how to properly report issues
found by research tools.

> Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>

And again, how do I know this is the correct address, it was sent from a
random gmail.com address.  Until I get some sort of confirmation from
the zte.com.cn developers that I can accept patches from patches outside
of their domain, I am going to be safe and not do so.

thanks,

greg k-h